On 6 January 2014 15:38, André Hentschel wrote:
> This warning seems wrong:
> - the if statement has no braces and only one arm
> - the if statement looks like the others around it, i just try to keep the
> same style
The warning is saying that you need braces. "all arms" for an
if() with only
> This looks ok, except that scripts/checkpatch.pl says:
>
> WARNING: braces {} are necessary for all arms of this statement
> #36: FILE: linux-user/syscall.c:2254:
> +if (get_user_ual(sockfd, vptr)
> [...]
>
> total: 0 errors, 1 warnings, 30 lines checked
>
> Fix
> Le 6 janvier 2014 à 10:14, Peter Maydell a écrit :
>
>
> On 6 January 2014 08:45, Laurent Vivier wrote:
> >
> >> Le 6 janvier 2014 à 02:57, André Hentschel a écrit :
> >> diff --git a/linux-user/syscall_defs.h b/linux-user/syscall_defs.h
> >> index cf08db5..b36f99c 100644
> >> --- a/linux-use
On 6 January 2014 08:45, Laurent Vivier wrote:
>
>> Le 6 janvier 2014 à 02:57, André Hentschel a écrit :
>> diff --git a/linux-user/syscall_defs.h b/linux-user/syscall_defs.h
>> index cf08db5..b36f99c 100644
>> --- a/linux-user/syscall_defs.h
>> +++ b/linux-user/syscall_defs.h
>> @@ -27,6 +27,9 @
> Le 6 janvier 2014 à 02:57, André Hentschel a écrit :
>
>
> From: André Hentschel
> Cc: Riku Voipio
> Signed-off-by: André Hentschel
[...]
> diff --git a/linux-user/syscall_defs.h b/linux-user/syscall_defs.h
> index cf08db5..b36f99c 100644
> --- a/linux-user/syscall_defs.h
> +++ b/linux-user/
Hi André,
This looks ok, except that scripts/checkpatch.pl says:
WARNING: braces {} are necessary for all arms of this statement
#36: FILE: linux-user/syscall.c:2254:
+if (get_user_ual(sockfd, vptr)
[...]
total: 0 errors, 1 warnings, 30 lines checked
Fix that and
From: André Hentschel
Cc: Riku Voipio
Signed-off-by: André Hentschel
---
See
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/include/uapi/linux/net.h
for the values.
Not entirely sure how to implement recvmmsg and sendmmsg...
linux-user/syscall.c | 15 +
