Re: [Qemu-devel] [PATCH for-2.5] bt: fix two struct sizes

2015-11-27 Thread Markus Armbruster
Paolo Bonzini writes: > On 27/11/2015 18:08, Markus Armbruster wrote: >>> > evt_encrypt_change 4 5 >> Used in bt_hci_event_encrypt_change(). I figure it makes bt_hci_event() >> overrun the destination by one byte. > > Yes, and Coverity complains. > >> Kernel has >> >>

Re: [Qemu-devel] [PATCH for-2.5] bt: fix two struct sizes

2015-11-27 Thread Paolo Bonzini
On 27/11/2015 18:08, Markus Armbruster wrote: >> > evt_encrypt_change 4 5 > Used in bt_hci_event_encrypt_change(). I figure it makes bt_hci_event() > overrun the destination by one byte. Yes, and Coverity complains. > Kernel has > > struct hci_ev_encrypt_change {

Re: [Qemu-devel] [PATCH for-2.5] bt: fix two struct sizes

2015-11-27 Thread Markus Armbruster
Markus Armbruster writes: > Paolo Bonzini writes: > >> On 27/11/2015 16:16, Markus Armbruster wrote: > >> Since you also fix RESET_FAILED_CONTACT_COUNTER_RP_SIZE, I assume you > >> checked them all. > >> > >> Reviewed-by: Markus Armbruster Retracted. > No, I just copied

Re: [Qemu-devel] [PATCH for-2.5] bt: fix two struct sizes

2015-11-27 Thread Markus Armbruster
Paolo Bonzini writes: > On 27/11/2015 16:16, Markus Armbruster wrote: >> Since you also fix RESET_FAILED_CONTACT_COUNTER_RP_SIZE, I assume you >> checked them all. >> >> Reviewed-by: Markus Armbruster >>> > >>> > No, I just copied the upstream bluez patch. >> At least CREATE

Re: [Qemu-devel] [PATCH for-2.5] bt: fix two struct sizes

2015-11-27 Thread Paolo Bonzini
On 27/11/2015 16:16, Markus Armbruster wrote: >>> >> Since you also fix RESET_FAILED_CONTACT_COUNTER_RP_SIZE, I assume you >>> >> checked them all. >>> >> >>> >> Reviewed-by: Markus Armbruster >> > >> > No, I just copied the upstream bluez patch. > At least CREATE_CONN_CANCEL_CP_SIZE is also wr

Re: [Qemu-devel] [PATCH for-2.5] bt: fix two struct sizes

2015-11-27 Thread Markus Armbruster
Paolo Bonzini writes: > On 27/11/2015 15:39, Markus Armbruster wrote: >> Since you also fix RESET_FAILED_CONTACT_COUNTER_RP_SIZE, I assume you >> checked them all. >> >> Reviewed-by: Markus Armbruster > > No, I just copied the upstream bluez patch. At least CREATE_CONN_CANCEL_CP_SIZE is also w

Re: [Qemu-devel] [PATCH for-2.5] bt: fix two struct sizes

2015-11-27 Thread Paolo Bonzini
On 27/11/2015 15:39, Markus Armbruster wrote: > Since you also fix RESET_FAILED_CONTACT_COUNTER_RP_SIZE, I assume you > checked them all. > > Reviewed-by: Markus Armbruster No, I just copied the upstream bluez patch. Paolo

Re: [Qemu-devel] [PATCH for-2.5] bt: fix two struct sizes

2015-11-27 Thread Markus Armbruster
Paolo Bonzini writes: > See http://permalink.gmane.org/gmane.linux.bluez.kernel/36505. For historical > reasons these do not use sizeof, and Coverity caught a mistake in > EVT_ENCRYPT_CHANGE_SIZE. > > Signed-off-by: Paolo Bonzini > --- > include/hw/bt.h | 4 ++-- > 1 file changed, 2 insertions

[Qemu-devel] [PATCH for-2.5] bt: fix two struct sizes

2015-11-27 Thread Paolo Bonzini
See http://permalink.gmane.org/gmane.linux.bluez.kernel/36505. For historical reasons these do not use sizeof, and Coverity caught a mistake in EVT_ENCRYPT_CHANGE_SIZE. Signed-off-by: Paolo Bonzini --- include/hw/bt.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/inclu