Paolo Bonzini <pbonz...@redhat.com> writes: > On 27/11/2015 16:16, Markus Armbruster wrote: >>>> >> Since you also fix RESET_FAILED_CONTACT_COUNTER_RP_SIZE, I assume you >>>> >> checked them all. >>>> >> >>>> >> Reviewed-by: Markus Armbruster <arm...@redhat.com> >>> > >>> > No, I just copied the upstream bluez patch. >> At least CREATE_CONN_CANCEL_CP_SIZE is also wrong. >> >> Any particular reason not to mass-convert to sizeof and call it a day? > > No particular reason, but it is bluetooth after all. :)
Okay, no need to say more. A bit of Emacs wizardry produced a test program, which coughed up three more: type sizeof() _SIZE create_conn_cancel_cp 7 6 reset_failed_contact_counter_rp 3 4 read_link_quality_cp 2 4 inquiry_info 15 14 evt_encrypt_change 4 5 I'll send a patch.