Re: [Qemu-devel] [PATCH V9 06/11] quorum: Add quorum mechanism.

2013-10-29 Thread Max Reitz
Am 28.10.2013 14:04, schrieb Benoît Canet: > Le Friday 04 Oct 2013 à 16:48:12 (+0200), Max Reitz a écrit : >> On 2013-10-02 14:39, Benoît Canet wrote: >>> Use gnutls's SHA-256 to compare versions. >> Wouldn't CRC32 suffice? (I don't really oppose using SHA, but taking >> in gnutls as a dependency j

Re: [Qemu-devel] [PATCH V9 06/11] quorum: Add quorum mechanism.

2013-10-29 Thread Max Reitz
Am 28.10.2013 13:31, schrieb Benoît Canet: > Le Friday 04 Oct 2013 à 16:48:12 (+0200), Max Reitz a écrit : >> On 2013-10-02 14:39, Benoît Canet wrote: >>> Use gnutls's SHA-256 to compare versions. >> Wouldn't CRC32 suffice? (I don't really oppose using SHA, but taking >> in gnutls as a dependency j

Re: [Qemu-devel] [PATCH V9 06/11] quorum: Add quorum mechanism.

2013-10-28 Thread Benoît Canet
Le Friday 04 Oct 2013 à 16:48:12 (+0200), Max Reitz a écrit : > On 2013-10-02 14:39, Benoît Canet wrote: > >Use gnutls's SHA-256 to compare versions. > Wouldn't CRC32 suffice? (I don't really oppose using SHA, but taking > in gnutls as a dependency just for comparing several memory areas > seems a

Re: [Qemu-devel] [PATCH V9 06/11] quorum: Add quorum mechanism.

2013-10-28 Thread Benoît Canet
Le Friday 04 Oct 2013 à 16:48:12 (+0200), Max Reitz a écrit : > On 2013-10-02 14:39, Benoît Canet wrote: > >Use gnutls's SHA-256 to compare versions. > Wouldn't CRC32 suffice? (I don't really oppose using SHA, but taking > in gnutls as a dependency just for comparing several memory areas > seems a

Re: [Qemu-devel] [PATCH V9 06/11] quorum: Add quorum mechanism.

2013-10-04 Thread Max Reitz
On 2013-10-02 14:39, Benoît Canet wrote: Use gnutls's SHA-256 to compare versions. Wouldn't CRC32 suffice? (I don't really oppose using SHA, but taking in gnutls as a dependency just for comparing several memory areas seems a bit much to me) Signed-off-by: Benoit Canet --- block/Makefile.

[Qemu-devel] [PATCH V9 06/11] quorum: Add quorum mechanism.

2013-10-02 Thread Benoît Canet
Use gnutls's SHA-256 to compare versions. Signed-off-by: Benoit Canet --- block/Makefile.objs | 2 +- block/quorum.c| 321 +- configure | 36 ++ include/monitor/monitor.h | 2 + monitor.c | 2