Am 28.10.2013 13:31, schrieb Benoît Canet: > Le Friday 04 Oct 2013 à 16:48:12 (+0200), Max Reitz a écrit : >> On 2013-10-02 14:39, Benoît Canet wrote: >>> Use gnutls's SHA-256 to compare versions. >> Wouldn't CRC32 suffice? (I don't really oppose using SHA, but taking >> in gnutls as a dependency just for comparing several memory areas >> seems a bit much to me) > Initially it gzip's addler32 was used but someone was concerned with the risk > of collisions. > Anyway the code fallback using hashes only when something wrong is detected so > it won't impact the normal case. > > Best regards > > Benoît
Yes, that's correct, but it adds a new dependency to qemu. Personally, I am unable to decide whether this is better than having a higher risk of collisions with CRC, so I'll leave the decision to someone more qualified (like you). ;-) Max
