Re: [Qemu-devel] [PATCH V5 5/5] machine: remove iommu property

2016-06-28 Thread David Gibson
On Tue, Jun 28, 2016 at 11:07:52AM +0300, Marcel Apfelbaum wrote: > On 06/28/2016 05:57 AM, David Gibson wrote: > > On Mon, Jun 27, 2016 at 06:38:35PM +0300, Marcel Apfelbaum wrote: > > > Since iommu devices can be created with '-device' there is > > > no need to keep iommu as machine and mch prope

Re: [Qemu-devel] [PATCH V5 5/5] machine: remove iommu property

2016-06-28 Thread Marcel Apfelbaum
On 06/28/2016 05:57 AM, David Gibson wrote: On Mon, Jun 27, 2016 at 06:38:35PM +0300, Marcel Apfelbaum wrote: Since iommu devices can be created with '-device' there is no need to keep iommu as machine and mch property. Doesn't this break backwards compatibility? Hi David, Intel IOMMU was

Re: [Qemu-devel] [PATCH V5 5/5] machine: remove iommu property

2016-06-27 Thread David Gibson
On Mon, Jun 27, 2016 at 06:38:35PM +0300, Marcel Apfelbaum wrote: > Since iommu devices can be created with '-device' there is > no need to keep iommu as machine and mch property. Doesn't this break backwards compatibility? > > Signed-off-by: Marcel Apfelbaum > --- > hw/core/machine.c

[Qemu-devel] [PATCH V5 5/5] machine: remove iommu property

2016-06-27 Thread Marcel Apfelbaum
Since iommu devices can be created with '-device' there is no need to keep iommu as machine and mch property. Signed-off-by: Marcel Apfelbaum --- hw/core/machine.c | 20 hw/pci-host/q35.c | 12 include/hw/pci-host/q35.h | 1 - qemu-options.hx