Re: [Qemu-devel] [PATCH RFC 02/16] vl: smp: add checks for maxcpus based topologies

2016-06-13 Thread Andrew Jones
On Tue, Jun 14, 2016 at 11:28:52AM +1000, David Gibson wrote: > On Fri, Jun 10, 2016 at 07:40:13PM +0200, Andrew Jones wrote: > > smp_parse computes missing smp options. Unfortunately cores and > > threads are computed by dividing smp_cpus, instead of max_cpus. > > This is incorrect because the top

Re: [Qemu-devel] [PATCH RFC 02/16] vl: smp: add checks for maxcpus based topologies

2016-06-13 Thread David Gibson
On Fri, Jun 10, 2016 at 07:40:13PM +0200, Andrew Jones wrote: > smp_parse computes missing smp options. Unfortunately cores and > threads are computed by dividing smp_cpus, instead of max_cpus. > This is incorrect because the topology doesn't leave room for > hotplug. More unfortunately, we can't c

[Qemu-devel] [PATCH RFC 02/16] vl: smp: add checks for maxcpus based topologies

2016-06-10 Thread Andrew Jones
smp_parse computes missing smp options. Unfortunately cores and threads are computed by dividing smp_cpus, instead of max_cpus. This is incorrect because the topology doesn't leave room for hotplug. More unfortunately, we can't change it easily, as doing so would impact existing command lines. This