Missed cc qemu-devel, added CC, sorry.
原始消息
主题: Re: [Qemu-devel] [PATCH RFC] remove QEMUOptionParameter
日期: Fri, 21 Sep 2012 10:43:12 +0800
发件人: Dong Xu Wang
收件人: Markus Armbruster
于 9/20/2012 5:16 PM, Markus Armbruster 写道:
> Dong Xu Wang writes:
>
>> Markus,
On Thu, 20 Sep 2012 11:10:02 +0800
Dong Xu Wang wrote:
> Luiz, I think I need to use your 1-3 patchs in your series.
> http://lists.nongnu.org/archive/html/qemu-devel/2012-07/msg02716.html
Sure, that's what I expected you'd do. Note that Markus made some
comments there that have to be addressed.
Dong Xu Wang writes:
> Markus, I am working with v2 and have some questions based your comments.
Your replies are very hard to read, because whatever you use to send
them wraps quoted lines. Please fix that.
> On Fri, Sep 7, 2012 at 4:42 PM, Markus Armbruster wrote:
>> Some overlap with what
On Tue, 11 Sep 2012 09:57:12 +0800
Dong Xu Wang wrote:
> >> >
> >> > -set_option_parameter_int(options, BLOCK_OPT_SIZE, total_size);
> >> > -set_option_parameter(options, BLOCK_OPT_BACKING_FILE,
> >> > backing_filename);
> >> > +snprintf(buf_total_size, sizeof(buf_total_s
Am 07.09.2012 10:42, schrieb Markus Armbruster:
>> @@ -1628,51 +1625,6 @@ static int qcow2_load_vmstate(BlockDriverState *bs,
>> uint8_t *buf,
>> return ret;
>> }
>>
>> -static QEMUOptionParameter qcow2_create_options[] = {
>> -{
>> -.name = BLOCK_OPT_SIZE,
>> -.type =
Some overlap with what I'm working on, but since you have code to show,
and I don't, I'll review yours as if mine didn't exist.
Dong Xu Wang writes:
> QEMU now has QEMUOptionParameter and QemuOpts to parse parameters, so we can
> remove one safely. This RFC removed QEMUOptionParameter and use Q
QEMU now has QEMUOptionParameter and QemuOpts to parse parameters, so we can
remove one safely. This RFC removed QEMUOptionParameter and use QemuOpts. But
the patch is not completed, I think it is better to send a RFC first. In the
RFC, I only allow qcow2 and raw file format and did not test it com
