Re: [Qemu-devel] [PATCH 43/47] mirror: allow customizing the granularity

2012-07-30 Thread Paolo Bonzini
Il 30/07/2012 15:53, Eric Blake ha scritto: > On 07/30/2012 07:40 AM, Paolo Bonzini wrote: >> Il 28/07/2012 15:43, Eric Blake ha scritto: > +if (granularity < 512 || granularity > 1048576 * 64) { > +error_set(errp, QERR_INVALID_PARAMETER, device); > +return; > +

Re: [Qemu-devel] [PATCH 43/47] mirror: allow customizing the granularity

2012-07-30 Thread Eric Blake
On 07/30/2012 07:40 AM, Paolo Bonzini wrote: > Il 28/07/2012 15:43, Eric Blake ha scritto: +if (granularity < 512 || granularity > 1048576 * 64) { +error_set(errp, QERR_INVALID_PARAMETER, device); +return; +} +if (granularity & (granularity - 1))

Re: [Qemu-devel] [PATCH 43/47] mirror: allow customizing the granularity

2012-07-30 Thread Paolo Bonzini
Il 28/07/2012 15:43, Eric Blake ha scritto: >> > +if (granularity < 512 || granularity > 1048576 * 64) { >> > +error_set(errp, QERR_INVALID_PARAMETER, device); >> > +return; >> > +} >> > +if (granularity & (granularity - 1)) { >> > +error_set(errp, QERR_INVALID_P

Re: [Qemu-devel] [PATCH 43/47] mirror: allow customizing the granularity

2012-07-28 Thread Eric Blake
On 07/24/2012 05:04 AM, Paolo Bonzini wrote: > The desired granularity may be very different depending on the kind of > operation (e.g. continous replication vs. collapse-to-raw) and whether s/continous/continuous/ > the VM is expected to perform lots of I/O while mirroring is in progress. > Allo

[Qemu-devel] [PATCH 43/47] mirror: allow customizing the granularity

2012-07-24 Thread Paolo Bonzini
The desired granularity may be very different depending on the kind of operation (e.g. continous replication vs. collapse-to-raw) and whether the VM is expected to perform lots of I/O while mirroring is in progress. Allow the user to customize it. Signed-off-by: Paolo Bonzini --- block/mirror.c