Il 28/07/2012 15:43, Eric Blake ha scritto:
>> > + if (granularity < 512 || granularity > 1048576 * 64) {
>> > + error_set(errp, QERR_INVALID_PARAMETER, device);
>> > + return;
>> > + }
>> > + if (granularity & (granularity - 1)) {
>> > + error_set(errp, QERR_INVALID_PARAMETER, device);
>> > + return;
> In the XBZLRE migration series, we decided to round the users input down
> to a power of two instead of reject it. Should we do that here?
I can certainly do that, but do you have a pointer to the discussion so
that I can understand the rationale?
> Also,
> there is already an explicit QERR_PROPERY_VALUE_NOT_POWER_OF_2 that
> might fit better here (depending on how the error cleanup series goes).
It's not a property value though.
Paolo
