Re: [Qemu-devel] [PATCH 3/5] PXB: convert to realize()

2015-12-22 Thread Cao jin
Hi, Marcel On 12/22/2015 05:35 PM, Marcel Apfelbaum wrote: On 12/22/2015 11:16 AM, Cao jin wrote: [...] Sure, just add something like: fprintf(stderr, "ds parent: %p, bus parent... ", ds->parent ...) Compile and run QEMU with a pxb device: -device pxb,bus=80,... And look for w

Re: [Qemu-devel] [PATCH 3/5] PXB: convert to realize()

2015-12-22 Thread Cao jin
On 12/22/2015 05:35 PM, Marcel Apfelbaum wrote: On 12/22/2015 11:16 AM, Cao jin wrote: On 12/22/2015 03:34 PM, Marcel Apfelbaum wrote: On 12/22/2015 05:58 AM, Cao jin wrote: On 12/21/2015 11:49 PM, Paolo Bonzini wrote: On 20/12/2015 12:38, Cao jin wrote: +object_unref(OBJECT(ds)

Re: [Qemu-devel] [PATCH 3/5] PXB: convert to realize()

2015-12-22 Thread Marcel Apfelbaum
On 12/22/2015 11:16 AM, Cao jin wrote: On 12/22/2015 03:34 PM, Marcel Apfelbaum wrote: On 12/22/2015 05:58 AM, Cao jin wrote: On 12/21/2015 11:49 PM, Paolo Bonzini wrote: On 20/12/2015 12:38, Cao jin wrote: +object_unref(OBJECT(ds)); +object_unref(OBJECT(bds)); +object_unre

Re: [Qemu-devel] [PATCH 3/5] PXB: convert to realize()

2015-12-22 Thread Cao jin
On 12/22/2015 03:34 PM, Marcel Apfelbaum wrote: On 12/22/2015 05:58 AM, Cao jin wrote: On 12/21/2015 11:49 PM, Paolo Bonzini wrote: On 20/12/2015 12:38, Cao jin wrote: +object_unref(OBJECT(ds)); +object_unref(OBJECT(bds)); +object_unref(OBJECT(bus)); I think these should b

Re: [Qemu-devel] [PATCH 3/5] PXB: convert to realize()

2015-12-21 Thread Marcel Apfelbaum
On 12/22/2015 05:58 AM, Cao jin wrote: On 12/21/2015 11:49 PM, Paolo Bonzini wrote: On 20/12/2015 12:38, Cao jin wrote: +object_unref(OBJECT(ds)); +object_unref(OBJECT(bds)); +object_unref(OBJECT(bus)); I think these should be object_unparent, not unref. But, it seems thes

Re: [Qemu-devel] [PATCH 3/5] PXB: convert to realize()

2015-12-21 Thread Cao jin
On 12/21/2015 11:49 PM, Paolo Bonzini wrote: On 20/12/2015 12:38, Cao jin wrote: +object_unref(OBJECT(ds)); +object_unref(OBJECT(bds)); +object_unref(OBJECT(bus)); I think these should be object_unparent, not unref. But, it seems these 3 objects isn`t added as a child-prope

Re: [Qemu-devel] [PATCH 3/5] PXB: convert to realize()

2015-12-21 Thread Paolo Bonzini
On 20/12/2015 12:38, Cao jin wrote: >>> >>> +object_unref(OBJECT(ds)); >>> +object_unref(OBJECT(bds)); >>> +object_unref(OBJECT(bus)); >> >> I think these should be object_unparent, not unref. >> > > But, it seems these 3 objects isn`t added as a child-property via > object_property_

Re: [Qemu-devel] [PATCH 3/5] PXB: convert to realize()

2015-12-21 Thread Cao jin
Hi Paolo On 12/20/2015 07:38 PM, Cao jin wrote: Hi On 12/19/2015 02:01 AM, Paolo Bonzini wrote: On 18/12/2015 12:03, Cao jin wrote: [...] + +err_register_bus: +object_unref(OBJECT(ds)); +object_unref(OBJECT(bds)); +object_unref(OBJECT(bus)); I think these should be object_unp

Re: [Qemu-devel] [PATCH 3/5] PXB: convert to realize()

2015-12-21 Thread Cao jin
On 12/21/2015 06:08 PM, Marcel Apfelbaum wrote: On 12/21/2015 04:59 AM, Cao jin wrote: [...] Another question: because some of this series is CCed to qemu-trivial(which means: reviewed-by?) by other maintainer, so next time, do I need to send the whole series with "v2", or the rest? Hi,

Re: [Qemu-devel] [PATCH 3/5] PXB: convert to realize()

2015-12-21 Thread Marcel Apfelbaum
On 12/21/2015 04:59 AM, Cao jin wrote: On 12/20/2015 07:21 PM, Marcel Apfelbaum wrote: On 12/20/2015 12:48 PM, Cao jin wrote: Hi, On 12/20/2015 06:22 PM, Marcel Apfelbaum wrote: [...] + +err_register_bus: +object_unref(OBJECT(ds)); +object_unref(OBJECT(bds)); +object_unref(OBJE

Re: [Qemu-devel] [PATCH 3/5] PXB: convert to realize()

2015-12-20 Thread Cao jin
On 12/20/2015 07:21 PM, Marcel Apfelbaum wrote: On 12/20/2015 12:48 PM, Cao jin wrote: Hi, On 12/20/2015 06:22 PM, Marcel Apfelbaum wrote: [...] + +err_register_bus: +object_unref(OBJECT(ds)); +object_unref(OBJECT(bds)); +object_unref(OBJECT(bus)); The order should be in the

Re: [Qemu-devel] [PATCH 3/5] PXB: convert to realize()

2015-12-20 Thread Cao jin
Hi On 12/19/2015 02:01 AM, Paolo Bonzini wrote: On 18/12/2015 12:03, Cao jin wrote: [...] + +err_register_bus: +object_unref(OBJECT(ds)); +object_unref(OBJECT(bds)); +object_unref(OBJECT(bus)); I think these should be object_unparent, not unref. But, it seems these 3 objects

Re: [Qemu-devel] [PATCH 3/5] PXB: convert to realize()

2015-12-20 Thread Marcel Apfelbaum
On 12/20/2015 12:48 PM, Cao jin wrote: Hi, On 12/20/2015 06:22 PM, Marcel Apfelbaum wrote: Hi, On 12/18/2015 01:03 PM, Cao jin wrote: Signed-off-by: Cao jin --- hw/pci-bridge/pci_expander_bridge.c | 24 ++-- 1 file changed, 14 insertions(+), 10 deletions(-) diff --gi

Re: [Qemu-devel] [PATCH 3/5] PXB: convert to realize()

2015-12-20 Thread Cao jin
Hi, On 12/20/2015 06:22 PM, Marcel Apfelbaum wrote: Hi, On 12/18/2015 01:03 PM, Cao jin wrote: Signed-off-by: Cao jin --- hw/pci-bridge/pci_expander_bridge.c | 24 ++-- 1 file changed, 14 insertions(+), 10 deletions(-) diff --git a/hw/pci-bridge/pci_expander_bridge.c

Re: [Qemu-devel] [PATCH 3/5] PXB: convert to realize()

2015-12-20 Thread Marcel Apfelbaum
Hi, On 12/18/2015 01:03 PM, Cao jin wrote: Signed-off-by: Cao jin --- hw/pci-bridge/pci_expander_bridge.c | 24 ++-- 1 file changed, 14 insertions(+), 10 deletions(-) diff --git a/hw/pci-bridge/pci_expander_bridge.c b/hw/pci-bridge/pci_expander_bridge.c index 57f8a37..

Re: [Qemu-devel] [PATCH 3/5] PXB: convert to realize()

2015-12-18 Thread Paolo Bonzini
On 18/12/2015 12:03, Cao jin wrote: > Signed-off-by: Cao jin > --- > hw/pci-bridge/pci_expander_bridge.c | 24 ++-- > 1 file changed, 14 insertions(+), 10 deletions(-) > > diff --git a/hw/pci-bridge/pci_expander_bridge.c > b/hw/pci-bridge/pci_expander_bridge.c > index 57f8

[Qemu-devel] [PATCH 3/5] PXB: convert to realize()

2015-12-18 Thread Cao jin
Signed-off-by: Cao jin --- hw/pci-bridge/pci_expander_bridge.c | 24 ++-- 1 file changed, 14 insertions(+), 10 deletions(-) diff --git a/hw/pci-bridge/pci_expander_bridge.c b/hw/pci-bridge/pci_expander_bridge.c index 57f8a37..cc975f6 100644 --- a/hw/pci-bridge/pci_expander_b