On 12/21/2015 11:49 PM, Paolo Bonzini wrote:
On 20/12/2015 12:38, Cao jin wrote:
+ object_unref(OBJECT(ds));
+ object_unref(OBJECT(bds));
+ object_unref(OBJECT(bus));
I think these should be object_unparent, not unref.
But, it seems these 3 objects isn`t added as a child-property via
object_property_add_child() during creation, so OBJECT(ds)->parent(so
does the other 2) will be NULL, and so object_unparent will do nothing?
qdev_init_nofail adds them (qdev_init_nofail -> object_property_set_bool
-> device_set_realized -> object_property_add_child).
If you haven't reached qdev_init_nofail, you should indeed unref ds and
bds instead. However, the bus should be unparented because pci_bus_new
makes it a child of ds (pci_bus_new -> qbus_create -> qbus_realize ->
object_property_add_child).
Yes...that`s true.
and @Marcel, I think maybe this is final decision?
Paolo
.
--
Yours Sincerely,
Cao Jin
