On 30 July 2012 18:20, Blue Swirl wrote:
> On Mon, Jul 30, 2012 at 5:09 PM, Peter Maydell
> wrote:
>> Not really, things would still need changing later. Really the
>> problem is that most of the function is #if 0'd out (and never
>> called from anywhere); it's just unused stub code so anything
On Mon, Jul 30, 2012 at 5:09 PM, Peter Maydell wrote:
> On 30 July 2012 17:59, Andreas Färber wrote:
>> Am 30.07.2012 18:13, schrieb Peter Maydell:
>>> This will need changing again if we ever fix the #if 0-d out
>>> code in this function, but I guess that will be obvious to whoever
>>> does that
On 30 July 2012 17:59, Andreas Färber wrote:
> Am 30.07.2012 18:13, schrieb Peter Maydell:
>> This will need changing again if we ever fix the #if 0-d out
>> code in this function, but I guess that will be obvious to whoever
>> does that.
>
> You mean the #endif part? Would an explicit err = 0 mak
Am 30.07.2012 18:13, schrieb Peter Maydell:
> On 30 July 2012 17:04, wrote:
>> From: Blue Swirl
>>
>> err was uninitalized, it's not OK to use |=. Spotted by Clang
>
> "uninitialized" (feel free to just fix typo on commit).
>
>> compiler.
>>
>> Fix by replacing |= by =.
>>
>> Signed-off-by: Bl
From: Blue Swirl
err was uninitalized, it's not OK to use |=. Spotted by Clang
compiler.
Fix by replacing |= by =.
Signed-off-by: Blue Swirl
---
linux-user/signal.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/linux-user/signal.c b/linux-user/signal.c
index 97f30d
On 30 July 2012 17:04, wrote:
> From: Blue Swirl
>
> err was uninitalized, it's not OK to use |=. Spotted by Clang
"uninitialized" (feel free to just fix typo on commit).
> compiler.
>
> Fix by replacing |= by =.
>
> Signed-off-by: Blue Swirl
> ---
> linux-user/signal.c |2 +-
> 1 files
