Re: [Qemu-devel] [PATCH 2/4] acpi/gpe: expand bits of gpe register

2013-05-27 Thread li guang
在 2013-05-27一的 11:00 +0200,Gerd Hoffmann写道: > On 05/24/13 04:02, li guang wrote: > > 在 2013-05-24五的 10:24 +0900,Isaku Yamahata写道: > >> On Wed, May 22, 2013 at 01:37:41PM +0800, li guang wrote: > >>> 在 2013-05-22三的 14:28 +0900,Isaku Yamahata写道: > Why? > And it breaks pointer operation like

Re: [Qemu-devel] [PATCH 2/4] acpi/gpe: expand bits of gpe register

2013-05-27 Thread Gerd Hoffmann
On 05/24/13 04:02, li guang wrote: > 在 2013-05-24五的 10:24 +0900,Isaku Yamahata写道: >> On Wed, May 22, 2013 at 01:37:41PM +0800, li guang wrote: >>> 在 2013-05-22三的 14:28 +0900,Isaku Yamahata写道: Why? And it breaks pointer operation like >>> >>> the fact is I can't guess why gpe->sts is defin

Re: [Qemu-devel] [PATCH 2/4] acpi/gpe: expand bits of gpe register

2013-05-27 Thread Gerd Hoffmann
On 05/24/13 04:02, li guang wrote: > 在 2013-05-24五的 10:24 +0900,Isaku Yamahata写道: >> On Wed, May 22, 2013 at 01:37:41PM +0800, li guang wrote: >>> 在 2013-05-22三的 14:28 +0900,Isaku Yamahata写道: Why? And it breaks pointer operation like >>> >>> the fact is I can't guess why gpe->sts is defin

Re: [Qemu-devel] [PATCH 2/4] acpi/gpe: expand bits of gpe register

2013-05-23 Thread li guang
在 2013-05-24五的 10:24 +0900,Isaku Yamahata写道: > On Wed, May 22, 2013 at 01:37:41PM +0800, li guang wrote: > > 在 2013-05-22三的 14:28 +0900,Isaku Yamahata写道: > > > Why? > > > And it breaks pointer operation like > > > > the fact is I can't guess why gpe->sts is defined uint8_t > > but the real hardwa

Re: [Qemu-devel] [PATCH 2/4] acpi/gpe: expand bits of gpe register

2013-05-23 Thread Isaku Yamahata
On Wed, May 22, 2013 at 01:37:41PM +0800, li guang wrote: > 在 2013-05-22三的 14:28 +0900,Isaku Yamahata写道: > > Why? > > And it breaks pointer operation like > > the fact is I can't guess why gpe->sts is defined uint8_t > but the real hardware is 32-bit width. Which section of ACPI spec? > I expa

Re: [Qemu-devel] [PATCH 2/4] acpi/gpe: expand bits of gpe register

2013-05-21 Thread li guang
在 2013-05-22三的 14:28 +0900,Isaku Yamahata写道: > Why? > And it breaks pointer operation like the fact is I can't guess why gpe->sts is defined uint8_t but the real hardware is 32-bit width. I expand it to 32 because the future usage for me will access bit beyond 8. of course, I can keep it, but I

Re: [Qemu-devel] [PATCH 2/4] acpi/gpe: expand bits of gpe register

2013-05-21 Thread Isaku Yamahata
Why? And it breaks pointer operation like > cur = ar->gpe.sts + addr; thanks, On Wed, May 22, 2013 at 11:46:35AM +0800, liguang wrote: > Signed-off-by: liguang > --- > hw/acpi/core.c |8 > hw/acpi/ich9.c |2 +- > hw/acpi/piix4.c|2 +- > inc

[Qemu-devel] [PATCH 2/4] acpi/gpe: expand bits of gpe register

2013-05-21 Thread liguang
Signed-off-by: liguang --- hw/acpi/core.c |8 hw/acpi/ich9.c |2 +- hw/acpi/piix4.c|2 +- include/hw/acpi/acpi.h |4 ++-- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/hw/acpi/core.c b/hw/acpi/core.c index 42eeace..38ddeb8 100644 -