On 09/09/2015 19:22, Peter Maydell wrote:
> On 7 September 2015 at 18:05, Markus Armbruster wrote:
>> Paolo Bonzini writes:
>>> That said, and even though Thomas obviously hasn't read the previous
>>> discussion, :) I do believe that 76 characters is too strict a limit.
>>
>> It's not a strict
On Wed, Sep 09, 2015 at 06:22:15PM +0100, Peter Maydell wrote:
> On 7 September 2015 at 18:05, Markus Armbruster wrote:
> > Paolo Bonzini writes:
> >> That said, and even though Thomas obviously hasn't read the previous
> >> discussion, :) I do believe that 76 characters is too strict a limit.
>
On Mon, Sep 07, 2015 at 06:06:25PM +0200, Paolo Bonzini wrote:
> On 07/09/2015 17:23, Markus Armbruster wrote:
> > > Apart from copy-n-pasting, there is also the problem that you can run
> > > "checkpatch.pl -f" on a whole file ... it would also be ugly to suddenly
> > > have (much) more warnings h
On Mon, Sep 07, 2015 at 07:02:55PM +0200, Thomas Huth wrote:
[...]
> We could maybe mention that 76 columns limit in the coding style
> document, to make people aware that they should start thinking about
> breaking lines in two when they reach 76 characters in a line. But
> changing checkpatch.pl
On 7 September 2015 at 18:05, Markus Armbruster wrote:
> Paolo Bonzini writes:
>> That said, and even though Thomas obviously hasn't read the previous
>> discussion, :) I do believe that 76 characters is too strict a limit.
>
> It's not a strict limit, it's a warning. The strict limit is 90.
I
On 09/07/2015 01:05 PM, Markus Armbruster wrote:
> Paolo Bonzini writes:
>
>> On 07/09/2015 17:23, Markus Armbruster wrote:
Apart from copy-n-pasting, there is also the problem that you can run
"checkpatch.pl -f" on a whole file ... it would also be ugly to suddenly
have (much) m
Paolo Bonzini writes:
> On 07/09/2015 17:23, Markus Armbruster wrote:
>> > Apart from copy-n-pasting, there is also the problem that you can run
>> > "checkpatch.pl -f" on a whole file ... it would also be ugly to suddenly
>> > have (much) more warnings here.
>>
>> Feature. If you run checkpatc
On 07/09/15 17:23, Markus Armbruster wrote:
> Thomas Huth writes:
>
>> On 07/09/15 16:22, Paolo Bonzini wrote:
>> [...]
>>> Some other interesting data:
>>>
>>> - However, only 605 files have 5 or more lines with 77+ columns, so the
>>> odds of warnings after copy-n-paste are pretty slim.
>>
>> A
Paolo Bonzini writes:
> On 07/09/2015 17:17, Markus Armbruster wrote:
>>> > + } elsif ($length > 76 && !($rawline =~ /^\+ \* /)) {
>>> > + # The BSD license blurb has 80 character lines.
>>> > + # Avoid warning on cut-and-pasted lice
On 07/09/2015 17:23, Markus Armbruster wrote:
> > Apart from copy-n-pasting, there is also the problem that you can run
> > "checkpatch.pl -f" on a whole file ... it would also be ugly to suddenly
> > have (much) more warnings here.
>
> Feature. If you run checkpatch on a whole file, you obviou
On 07/09/2015 17:17, Markus Armbruster wrote:
>> > + } elsif ($length > 76 && !($rawline =~ /^\+ \* /)) {
>> > + # The BSD license blurb has 80 character lines.
>> > + # Avoid warning on cut-and-pasted license text.
> Why not simp
Thomas Huth writes:
> On 07/09/15 16:22, Paolo Bonzini wrote:
>>
>> On 07/09/2015 15:18, Thomas Huth wrote:
>>> On 07/09/15 11:53, Paolo Bonzini wrote:
Line lengths above 80 characters do exist. They are rare, but
they happen from time to time. An ignored rule is worse than an
e
Paolo Bonzini writes:
> Line lengths above 80 characters do exist. They are rare, but
> they happen from time to time. An ignored rule is worse than an
> exception to the rule, so do the latter.
>
> Based on remarks from the list, make the preferred line length
> slightly lower than 80 characte
On 07/09/15 16:22, Paolo Bonzini wrote:
>
> On 07/09/2015 15:18, Thomas Huth wrote:
>> On 07/09/15 11:53, Paolo Bonzini wrote:
>>> Line lengths above 80 characters do exist. They are rare, but
>>> they happen from time to time. An ignored rule is worse than an
>>> exception to the rule, so do th
On 07/09/2015 15:18, Thomas Huth wrote:
> On 07/09/15 11:53, Paolo Bonzini wrote:
>> Line lengths above 80 characters do exist. They are rare, but
>> they happen from time to time. An ignored rule is worse than an
>> exception to the rule, so do the latter.
>>
>> Based on remarks from the list,
On 07/09/15 11:53, Paolo Bonzini wrote:
> Line lengths above 80 characters do exist. They are rare, but
> they happen from time to time. An ignored rule is worse than an
> exception to the rule, so do the latter.
>
> Based on remarks from the list, make the preferred line length
> slightly lower
Line lengths above 80 characters do exist. They are rare, but
they happen from time to time. An ignored rule is worse than an
exception to the rule, so do the latter.
Based on remarks from the list, make the preferred line length
slightly lower than 80 characters, to account for extra characters
17 matches
Mail list logo
