On Wed, Sep 09, 2015 at 06:22:15PM +0100, Peter Maydell wrote: > On 7 September 2015 at 18:05, Markus Armbruster <arm...@redhat.com> wrote: > > Paolo Bonzini <pbonz...@redhat.com> writes: > >> That said, and even though Thomas obviously hasn't read the previous > >> discussion, :) I do believe that 76 characters is too strict a limit. > > > > It's not a strict limit, it's a warning. The strict limit is 90. > > I tend to bounce patches on review for checkpatch warnings... > I don't make much distinction between a warning and an error.
If there are existing warnings that will make you bounce patches automatically, shouldn't they become errors? I believe there are things we want to warn people about on checkpatch.pl because they should be discouraged (like lines a bit longer than 76^H^H78^H^H79 columns), but that shouldn't make a patch be automatically rejected. -- Eduardo
