Re: [Qemu-devel] [PATCH 2/2] vga: Fix portio list conversion fallouts

2011-09-19 Thread Avi Kivity
On 09/18/2011 10:07 PM, Jan Kiszka wrote: > I don't think it should be deduplicated. The device is providing two > separate ABIs. Yes, two ABIs, and the only difference is the offset of the data register. How about #ifdef TARGET_I386 # define VBE_DATA_REG 1 #else # define VBE_DATA_REG 2 #e

Re: [Qemu-devel] [PATCH 2/2] vga: Fix portio list conversion fallouts

2011-09-18 Thread Jan Kiszka
On 2011-09-18 18:51, Avi Kivity wrote: > On 09/18/2011 07:28 PM, Jan Kiszka wrote: >> On 2011-09-18 17:51, Avi Kivity wrote: >> > On 09/18/2011 03:44 PM, Jan Kiszka wrote: >> >> From: Jan Kiszka >> >> >> >> Fix copy&paste errors and reduce duplications of the BOCHS VBE >> ranges. >> >> >> >> Si

Re: [Qemu-devel] [PATCH 2/2] vga: Fix portio list conversion fallouts

2011-09-18 Thread Avi Kivity
On 09/18/2011 07:28 PM, Jan Kiszka wrote: On 2011-09-18 17:51, Avi Kivity wrote: > On 09/18/2011 03:44 PM, Jan Kiszka wrote: >> From: Jan Kiszka >> >> Fix copy&paste errors and reduce duplications of the BOCHS VBE ranges. >> >> Signed-off-by: Jan Kiszka >> --- >> >>#ifdef CONFIG_BOCHS_VB

Re: [Qemu-devel] [PATCH 2/2] vga: Fix portio list conversion fallouts

2011-09-18 Thread Jan Kiszka
On 2011-09-18 17:51, Avi Kivity wrote: > On 09/18/2011 03:44 PM, Jan Kiszka wrote: >> From: Jan Kiszka >> >> Fix copy&paste errors and reduce duplications of the BOCHS VBE ranges. >> >> Signed-off-by: Jan Kiszka >> --- >> >> #ifdef CONFIG_BOCHS_VBE >> static const MemoryRegionPortio vbe_portio_

Re: [Qemu-devel] [PATCH 2/2] vga: Fix portio list conversion fallouts

2011-09-18 Thread Avi Kivity
On 09/18/2011 03:44 PM, Jan Kiszka wrote: From: Jan Kiszka Fix copy&paste errors and reduce duplications of the BOCHS VBE ranges. Signed-off-by: Jan Kiszka --- #ifdef CONFIG_BOCHS_VBE static const MemoryRegionPortio vbe_portio_list[] = { -# ifdef TARGET_I386 { 0, 1, 2, .read = vbe_io

[Qemu-devel] [PATCH 2/2] vga: Fix portio list conversion fallouts

2011-09-18 Thread Jan Kiszka
From: Jan Kiszka Fix copy&paste errors and reduce duplications of the BOCHS VBE ranges. Signed-off-by: Jan Kiszka --- This and the previous patch unbreaks VGA over memory/master. hw/vga.c |9 - 1 files changed, 4 insertions(+), 5 deletions(-) diff --git a/hw/vga.c b/hw/vga.c ind