Re: [Qemu-devel] [PATCH 2/2] trace: show MemoryRegion name, not address

2015-11-24 Thread Stefan Hajnoczi
On Tue, Nov 17, 2015 at 04:37:48PM -0800, Hollis Blanchard wrote: > On 11/13/2015 02:23 AM, Stefan Hajnoczi wrote: > >On Wed, Nov 11, 2015 at 05:09:58PM -0800, Hollis Blanchard wrote: > >>Recording the MemoryRegion pointers isn't helpful, especially since no trace > >>data allows us to correlate th

Re: [Qemu-devel] [PATCH 2/2] trace: show MemoryRegion name, not address

2015-11-17 Thread Hollis Blanchard
On 11/13/2015 02:23 AM, Stefan Hajnoczi wrote: On Wed, Nov 11, 2015 at 05:09:58PM -0800, Hollis Blanchard wrote: Recording the MemoryRegion pointers isn't helpful, especially since no trace data allows us to correlate those pointers to devices. Instead, record the MemoryRegion name. Signed-off-

Re: [Qemu-devel] [PATCH 2/2] trace: show MemoryRegion name, not address

2015-11-13 Thread Paolo Bonzini
On 13/11/2015 11:23, Stefan Hajnoczi wrote: >> > tmp = mr->ops->old_mmio.read[ctz32(size)](mr->opaque, addr); >> > -trace_memory_region_ops_read(mr, addr, tmp, size); >> > +trace_memory_region_ops_read(mr->name, addr, tmp, size); > mr->name may be NULL. There is a memory_region_name

Re: [Qemu-devel] [PATCH 2/2] trace: show MemoryRegion name, not address

2015-11-13 Thread Stefan Hajnoczi
On Wed, Nov 11, 2015 at 05:09:58PM -0800, Hollis Blanchard wrote: > Recording the MemoryRegion pointers isn't helpful, especially since no trace > data allows us to correlate those pointers to devices. Instead, record the > MemoryRegion name. > > Signed-off-by: Hollis Blanchard > --- > memory.c

[Qemu-devel] [PATCH 2/2] trace: show MemoryRegion name, not address

2015-11-11 Thread Hollis Blanchard
Recording the MemoryRegion pointers isn't helpful, especially since no trace data allows us to correlate those pointers to devices. Instead, record the MemoryRegion name. Signed-off-by: Hollis Blanchard --- memory.c | 12 ++-- trace-events | 4 ++-- 2 files changed, 8 insertions(+),