Re: [Qemu-devel] [PATCH 2/2] sheepdog: support 'qemu-img snapshot -a'

2013-06-07 Thread Liu Yuan
On 06/08/2013 12:48 AM, Kevin Wolf wrote: > Hm, yes, I was confused. :-) > > Anyway, the options stay the same: Either C1 must somehow inherit the VM > state from A on the Sheepdog level, or we must make sure to get this > order: > > 1. Switch to (read-only) snapshot A > 2. Load the VM state > 3.

Re: [Qemu-devel] [PATCH 2/2] sheepdog: support 'qemu-img snapshot -a'

2013-06-07 Thread Kevin Wolf
Am 07.06.2013 um 18:14 hat Liu Yuan geschrieben: > On 06/07/2013 11:22 PM, Kevin Wolf wrote: > > Am 07.06.2013 um 15:48 hat Liu Yuan geschrieben: > >> On 06/07/2013 03:31 PM, Kevin Wolf wrote: > >>> Am 06.06.2013 um 15:09 hat Liu Yuan geschrieben: > On 06/06/2013 08:46 PM, Kevin Wolf wrote: >

Re: [Qemu-devel] [PATCH 2/2] sheepdog: support 'qemu-img snapshot -a'

2013-06-07 Thread Liu Yuan
On 06/07/2013 11:22 PM, Kevin Wolf wrote: > Am 07.06.2013 um 15:48 hat Liu Yuan geschrieben: >> On 06/07/2013 03:31 PM, Kevin Wolf wrote: >>> Am 06.06.2013 um 15:09 hat Liu Yuan geschrieben: On 06/06/2013 08:46 PM, Kevin Wolf wrote: > Am 06.06.2013 um 13:57 hat Liu Yuan geschrieben: O

Re: [Qemu-devel] [PATCH 2/2] sheepdog: support 'qemu-img snapshot -a'

2013-06-07 Thread Kevin Wolf
Am 07.06.2013 um 15:48 hat Liu Yuan geschrieben: > On 06/07/2013 03:31 PM, Kevin Wolf wrote: > > Am 06.06.2013 um 15:09 hat Liu Yuan geschrieben: > >> On 06/06/2013 08:46 PM, Kevin Wolf wrote: > >>> Am 06.06.2013 um 13:57 hat Liu Yuan geschrieben: > >> Only when the write comes from VM, we do the f

Re: [Qemu-devel] [PATCH 2/2] sheepdog: support 'qemu-img snapshot -a'

2013-06-07 Thread Liu Yuan
On 06/07/2013 03:31 PM, Kevin Wolf wrote: > Am 06.06.2013 um 15:09 hat Liu Yuan geschrieben: >> On 06/06/2013 08:46 PM, Kevin Wolf wrote: >>> Am 06.06.2013 um 13:57 hat Liu Yuan geschrieben: Just call sd_create_branch() to rollback the image is good enough Cc: qemu-devel@nongnu.org >

Re: [Qemu-devel] [PATCH 2/2] sheepdog: support 'qemu-img snapshot -a'

2013-06-07 Thread Kevin Wolf
Am 06.06.2013 um 15:09 hat Liu Yuan geschrieben: > On 06/06/2013 08:46 PM, Kevin Wolf wrote: > > Am 06.06.2013 um 13:57 hat Liu Yuan geschrieben: > >> Just call sd_create_branch() to rollback the image is good enough > >> > >> Cc: qemu-devel@nongnu.org > >> Cc: MORITA Kazutaka > >> Cc: Kevin Wolf

Re: [Qemu-devel] [PATCH 2/2] sheepdog: support 'qemu-img snapshot -a'

2013-06-06 Thread Liu Yuan
On 06/06/2013 08:46 PM, Kevin Wolf wrote: > I'm not sure how snapshots work internally for Sheepdog, but it seems > odd to me that you need to do this only for disk-only snapshots, but not > when the snapshot has VM state. (Also, note that 'qemu-img snapshot -a' > works on images with a VM state, s

Re: [Qemu-devel] [PATCH 2/2] sheepdog: support 'qemu-img snapshot -a'

2013-06-06 Thread Liu Yuan
On 06/06/2013 08:46 PM, Kevin Wolf wrote: > Am 06.06.2013 um 13:57 hat Liu Yuan geschrieben: >> Just call sd_create_branch() to rollback the image is good enough >> >> Cc: qemu-devel@nongnu.org >> Cc: MORITA Kazutaka >> Cc: Kevin Wolf >> Cc: Stefan Hajnoczi >> Signed-off-by: Liu Yuan >> --- >>

Re: [Qemu-devel] [PATCH 2/2] sheepdog: support 'qemu-img snapshot -a'

2013-06-06 Thread Kevin Wolf
Am 06.06.2013 um 13:57 hat Liu Yuan geschrieben: > Just call sd_create_branch() to rollback the image is good enough > > Cc: qemu-devel@nongnu.org > Cc: MORITA Kazutaka > Cc: Kevin Wolf > Cc: Stefan Hajnoczi > Signed-off-by: Liu Yuan > --- > block/sheepdog.c |8 +--- > 1 file changed,

[Qemu-devel] [PATCH 2/2] sheepdog: support 'qemu-img snapshot -a'

2013-06-06 Thread Liu Yuan
Just call sd_create_branch() to rollback the image is good enough Cc: qemu-devel@nongnu.org Cc: MORITA Kazutaka Cc: Kevin Wolf Cc: Stefan Hajnoczi Signed-off-by: Liu Yuan --- block/sheepdog.c |8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/block/sheepdog.c b/blo