On 06/06/2013 08:46 PM, Kevin Wolf wrote: > I'm not sure how snapshots work internally for Sheepdog, but it seems > odd to me that you need to do this only for disk-only snapshots, but not > when the snapshot has VM state. (Also, note that 'qemu-img snapshot -a' > works on images with a VM state, so the comment doesn't seem to be > completely accurate)
Seems that I misunderstood your comments. What my 2/2 patch tried to do is enable 'qemu-img snapshot -a' to rollback the sheepdog disk states only and it is correct. So what I need fixing is comment, right? how about the commenting as 'qemu-img asks us to rollback disk only, we can't rely on the write request to sd_create_branch, so just call it directly' ? Thanks, Yuan
