Re: [Qemu-devel] [PATCH 2/2] Hw: timer: Remove unnecessary variable

2015-10-08 Thread Michael Tokarev
05.10.2015 18:29, Eric Blake wrote: > On 10/03/2015 10:59 AM, Michael Tokarev wrote: >> 25.09.2015 17:36, Shraddha Barke wrote: >>> Compress lines and remove the variable. >> >> Applied to -trivial, removing the Coccinelle script >> from the commit message. > > Why cripple the commit message? The

Re: [Qemu-devel] [PATCH 2/2] Hw: timer: Remove unnecessary variable

2015-10-05 Thread Eric Blake
On 10/03/2015 10:59 AM, Michael Tokarev wrote: > 25.09.2015 17:36, Shraddha Barke wrote: >> Compress lines and remove the variable. > > Applied to -trivial, removing the Coccinelle script > from the commit message. Why cripple the commit message? The coccinelle recipe is useful for someone trying

Re: [Qemu-devel] [PATCH 2/2] Hw: timer: Remove unnecessary variable

2015-10-03 Thread Michael Tokarev
25.09.2015 17:36, Shraddha Barke wrote: > Compress lines and remove the variable. Applied to -trivial, removing the Coccinelle script from the commit message. Thanks, /mjt

[Qemu-devel] [PATCH 2/2] Hw: timer: Remove unnecessary variable

2015-09-25 Thread Shraddha Barke
Compress lines and remove the variable. Change made using Coccinelle script @@ expression ret; @@ - if (ret) return ret; - return 0; + return ret; @@ local idexpression ret; expression e; @@ - ret = e; - return ret; + return e; @@ type T; identifier i; @@ - T i; ... when != i Signed-off-by: Shra