05.10.2015 18:29, Eric Blake wrote: > On 10/03/2015 10:59 AM, Michael Tokarev wrote: >> 25.09.2015 17:36, Shraddha Barke wrote: >>> Compress lines and remove the variable. >> >> Applied to -trivial, removing the Coccinelle script >> from the commit message. > > Why cripple the commit message? The coccinelle recipe is useful for > someone trying to backport the script to a different branch where a > straight backport doesn't quite work, but rerunning the coccinelle > recipe does.
I already answered to this one. Becuase git commit messages are not a good place to store various good scripts and recipes like this, and these scripts wont be found there anyway. On the other hand, cluttering commit messages with such info makes is significantly more difficult to find changes when you look for breakage or actual changes somewhere. Additionally, your point about backporting is kind of moot, there's very very little reason to backport these changes (especially using the supplied script), and if the backporting is really necessary and the patch does not apply (which is twice unlikely) it is much easier to do the patching manually based on the very smal difference here. Thanks, /mjt
