Re: [Qemu-devel] [PATCH 19/71] tests: qgraph API for the qtest driver framework

2018-12-12 Thread Thomas Huth
On 2018-12-12 12:09, Paolo Bonzini wrote: > On 07/12/18 16:38, Thomas Huth wrote: >> I did not do a very detailed review, but from a quick glance, this looks >> quite good to me already (apart from the few minor issues that I've >> mentioned above) >> >> Thomas > > Good, if this is okay for you,

Re: [Qemu-devel] [PATCH 19/71] tests: qgraph API for the qtest driver framework

2018-12-12 Thread Paolo Bonzini
On 07/12/18 16:38, Thomas Huth wrote: > I did not do a very detailed review, but from a quick glance, this looks > quite good to me already (apart from the few minor issues that I've > mentioned above) > > Thomas Good, if this is okay for you, my plan is the following: - send patches 1-18 in my

Re: [Qemu-devel] [PATCH 19/71] tests: qgraph API for the qtest driver framework

2018-12-07 Thread Thomas Huth
On 2018-12-03 16:32, Paolo Bonzini wrote: > From: Emanuele Giuseppe Esposito > > Add qgraph API that allows to add/remove nodes and edges from the graph, > implementation of Depth First Search to discover the paths and basic unit > test to check correctness of the API. > Included also a main exec

Re: [Qemu-devel] [PATCH 19/71] tests: qgraph API for the qtest driver framework

2018-12-07 Thread Paolo Bonzini
On 07/12/18 13:42, Thomas Huth wrote: > The license statement is inaccurate. There is no "GNU *Lesser* General > Public License version *2*" ... so I'm assuming you wanted to use one of > these two options: > > - GNU Library General Public License, version 2.0 > - GNU Lesser General Public License

Re: [Qemu-devel] [PATCH 19/71] tests: qgraph API for the qtest driver framework

2018-12-07 Thread Thomas Huth
On 2018-12-03 16:32, Paolo Bonzini wrote: > From: Emanuele Giuseppe Esposito > > Add qgraph API that allows to add/remove nodes and edges from the graph, > implementation of Depth First Search to discover the paths and basic unit > test to check correctness of the API. > Included also a main exec

[Qemu-devel] [PATCH 19/71] tests: qgraph API for the qtest driver framework

2018-12-03 Thread Paolo Bonzini
From: Emanuele Giuseppe Esposito Add qgraph API that allows to add/remove nodes and edges from the graph, implementation of Depth First Search to discover the paths and basic unit test to check correctness of the API. Included also a main executable that takes care of starting the framework, crea