Re: [Qemu-devel] [PATCH 13/14] ppc: inline ppc_set_crf when clearer

2014-09-19 Thread Paolo Bonzini
Il 18/09/2014 22:33, Tom Musta ha scritto: >> > Do not go through the loop when we're setting the four CR fields to >> > separate constants or conditions. This is clearer than putting together >> > 4-bit value and passing it. > I guess "clearer" is in the eye of the beholder :) > > In genera

Re: [Qemu-devel] [PATCH 13/14] ppc: inline ppc_set_crf when clearer

2014-09-18 Thread Tom Musta
On 9/15/2014 10:03 AM, Paolo Bonzini wrote: > Do not go through the loop when we're setting the four CR fields to > separate constants or conditions. This is clearer than putting together > 4-bit value and passing it. I guess "clearer" is in the eye of the beholder :) In general, replacing

[Qemu-devel] [PATCH 13/14] ppc: inline ppc_set_crf when clearer

2014-09-15 Thread Paolo Bonzini
Do not go through the loop when we're setting the four CR fields to separate constants or conditions. This is clearer than putting together 4-bit value and passing it. Signed-off-by: Paolo Bonzini --- v1->v2: due to previous changes, ppc_get_crf never needs this treatment, so I a