Il 18/09/2014 22:33, Tom Musta ha scritto: >> > Do not go through the loop when we're setting the four CR fields to >> > separate constants or conditions. This is clearer than putting together >> > 4-bit value and passing it. > I guess "clearer" is in the eye of the beholder .... :) > > In general, replacing a single line of code with four is not a simplification > (IMO). > > That said, I was not able to spot or identify by testing any functional > problems with this patch. >
True. It is better to say that it avoids messing with bit endianness. Paolo
