[Qemu-devel] [PATCH 1/9] main-loop: use qemu_mutex_lock_iothread consistently

2015-07-02 Thread Paolo Bonzini
The next patch will require the BQL to be always taken with qemu_mutex_lock_iothread(), while right now this isn't the case. Outside TCG mode this is not a problem. In TCG mode, we need to be careful and avoid the "prod out of compiled code" step if already in a VCPU thread. This is easily done

Re: [Qemu-devel] [PATCH 1/9] main-loop: use qemu_mutex_lock_iothread consistently

2015-06-25 Thread Paolo Bonzini
On 25/06/2015 05:39, Fam Zheng wrote: > On Wed, 06/24 18:25, Paolo Bonzini wrote: >> The next patch will require the BQL to be always taken with >> qemu_mutex_lock_iothread(), while right now this isn't the case. >> >> Outside TCG mode this is not a problem. In TCG mode, we need to be >> careful

Re: [Qemu-devel] [PATCH 1/9] main-loop: use qemu_mutex_lock_iothread consistently

2015-06-24 Thread Fam Zheng
On Wed, 06/24 18:25, Paolo Bonzini wrote: > The next patch will require the BQL to be always taken with > qemu_mutex_lock_iothread(), while right now this isn't the case. > > Outside TCG mode this is not a problem. In TCG mode, we need to be > careful and avoid the "prod out of compiled code" ste

[Qemu-devel] [PATCH 1/9] main-loop: use qemu_mutex_lock_iothread consistently

2015-06-24 Thread Paolo Bonzini
The next patch will require the BQL to be always taken with qemu_mutex_lock_iothread(), while right now this isn't the case. Outside TCG mode this is not a problem. In TCG mode, we need to be careful and avoid the "prod out of compiled code" step if already in a VCPU thread. This is easily done

Re: [Qemu-devel] [PATCH 1/9] main-loop: use qemu_mutex_lock_iothread consistently

2015-06-23 Thread Frederic Konrad
On 23/06/2015 15:56, Paolo Bonzini wrote: On 23/06/2015 15:49, Frederic Konrad wrote: Hopefully, multithreaded TCG will get rid of the whole logic to kick VCPUs whenever an I/O event occurs! Hopefully :), this means dropping the iothread mutex as soon as possible and removing the iothread_requ

Re: [Qemu-devel] [PATCH 1/9] main-loop: use qemu_mutex_lock_iothread consistently

2015-06-23 Thread Paolo Bonzini
On 23/06/2015 15:49, Frederic Konrad wrote: >> >> Hopefully, multithreaded TCG will get rid of the whole logic to kick >> VCPUs whenever an I/O event occurs! > Hopefully :), this means dropping the iothread mutex as soon as possible > and removing the iothread_requesting_mutex I guess.. Yes---ru

Re: [Qemu-devel] [PATCH 1/9] main-loop: use qemu_mutex_lock_iothread consistently

2015-06-23 Thread Frederic Konrad
On 18/06/2015 18:47, Paolo Bonzini wrote: The next patch will require the BQL to be always taken with qemu_mutex_lock_iothread(), while right now this isn't the case. Outside TCG mode this is not a problem. In TCG mode, we need to be careful and avoid the "prod out of compiled code" step if alr

[Qemu-devel] [PATCH 1/9] main-loop: use qemu_mutex_lock_iothread consistently

2015-06-18 Thread Paolo Bonzini
The next patch will require the BQL to be always taken with qemu_mutex_lock_iothread(), while right now this isn't the case. Outside TCG mode this is not a problem. In TCG mode, we need to be careful and avoid the "prod out of compiled code" step if already in a VCPU thread. This is easily done