Re: [Qemu-devel] [PATCH 1/3] Start moving migration code into a migration directory

2014-11-03 Thread Eduardo Habkost
On Mon, Nov 03, 2014 at 08:53:54AM +, Dr. David Alan Gilbert wrote: [...] > > But tidy organization is a good thing while needless renaming is not. The > > only goal that the suggested renames would appear to accomplish is > > additional obfuscation. How about just moving them into a subdirecto

Re: [Qemu-devel] [PATCH 1/3] Start moving migration code into a migration directory

2014-11-03 Thread Dr. David Alan Gilbert
* Gary Hook (gary.h...@nimboxx.com) wrote: > > > On 10/30/14, 7:26 AM, "Amit Shah" wrote: > > >On (Thu) 16 Oct 2014 [08:53:52], Dr. David Alan Gilbert (git) wrote: > >> From: "Dr. David Alan Gilbert" > >> > >> The migration code now occupies a fair chunk of the top level .c > >> files, it see

Re: [Qemu-devel] [PATCH 1/3] Start moving migration code into a migration directory

2014-10-31 Thread Peter Maydell
On 30 October 2014 12:37, Dr. David Alan Gilbert wrote: > * Amit Shah (amit.s...@redhat.com) wrote: >> On (Thu) 16 Oct 2014 [08:53:52], Dr. David Alan Gilbert (git) wrote: >> >> > rename migration-exec.c => migration/migration-exec.c (100%) >> > rename migration-fd.c => migration/migration-fd.c

Re: [Qemu-devel] [PATCH 1/3] Start moving migration code into a migration directory

2014-10-31 Thread Gary Hook
On 10/30/14, 7:26 AM, "Amit Shah" wrote: >On (Thu) 16 Oct 2014 [08:53:52], Dr. David Alan Gilbert (git) wrote: >> From: "Dr. David Alan Gilbert" >> >> The migration code now occupies a fair chunk of the top level .c >> files, it seems time to give it it's own directory. > >s/it's/its 6 out o

Re: [Qemu-devel] [PATCH 1/3] Start moving migration code into a migration directory

2014-10-31 Thread Dr. David Alan Gilbert
* Peter Maydell (peter.mayd...@linaro.org) wrote: > On 16 October 2014 08:53, Dr. David Alan Gilbert (git) > wrote: > > From: "Dr. David Alan Gilbert" > > > > The migration code now occupies a fair chunk of the top level .c > > files, it seems time to give it it's own directory. > > Missed oppor

Re: [Qemu-devel] [PATCH 1/3] Start moving migration code into a migration directory

2014-10-31 Thread Amit Shah
On (Thu) 16 Oct 2014 [08:53:52], Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > The migration code now occupies a fair chunk of the top level .c > files, it seems time to give it it's own directory. s/it's/its > I've not touched: >arch_init.c - that's mostly RAM mi

Re: [Qemu-devel] [PATCH 1/3] Start moving migration code into a migration directory

2014-10-31 Thread Peter Maydell
On 16 October 2014 08:53, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > The migration code now occupies a fair chunk of the top level .c > files, it seems time to give it it's own directory. Missed opportunity to make the patch summary line "Start migrating migration c

Re: [Qemu-devel] [PATCH 1/3] Start moving migration code into a migration directory

2014-10-31 Thread Dr. David Alan Gilbert
* Amit Shah (amit.s...@redhat.com) wrote: > On (Thu) 16 Oct 2014 [08:53:52], Dr. David Alan Gilbert (git) wrote: > > > rename migration-exec.c => migration/migration-exec.c (100%) > > rename migration-fd.c => migration/migration-fd.c (100%) > > rename migration-rdma.c => migration/migration-rdm

Re: [Qemu-devel] [PATCH 1/3] Start moving migration code into a migration directory

2014-10-31 Thread Amit Shah
On (Thu) 16 Oct 2014 [08:53:52], Dr. David Alan Gilbert (git) wrote: > rename migration-exec.c => migration/migration-exec.c (100%) > rename migration-fd.c => migration/migration-fd.c (100%) > rename migration-rdma.c => migration/migration-rdma.c (100%) > rename migration-tcp.c => migration/mi

Re: [Qemu-devel] [PATCH 1/3] Start moving migration code into a migration directory

2014-10-31 Thread Amit Shah
On (Thu) 30 Oct 2014 [12:37:27], Dr. David Alan Gilbert wrote: > * Amit Shah (amit.s...@redhat.com) wrote: > > On (Thu) 16 Oct 2014 [08:53:52], Dr. David Alan Gilbert (git) wrote: > > > > > rename migration-exec.c => migration/migration-exec.c (100%) > > > rename migration-fd.c => migration/migr

Re: [Qemu-devel] [PATCH 1/3] Start moving migration code into a migration directory

2014-10-20 Thread Paolo Bonzini
On 10/16/2014 10:12 AM, Dr. David Alan Gilbert wrote: Yes; I suspect it's the vmstate_register_ram that uses TARGET_PAGE_MASK, one of the patches in my postcopy world adds a function in exec.c that returns TARGET_PAGE_BITS so that stuff that needs to know target page size can make a call to find

Re: [Qemu-devel] [PATCH 1/3] Start moving migration code into a migration directory

2014-10-16 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > "Dr. David Alan Gilbert (git)" wrote: > G> From: "Dr. David Alan Gilbert" > > > > The migration code now occupies a fair chunk of the top level .c > > files, it seems time to give it it's own directory. > > > > I've not touched: > >arch_init.c -

Re: [Qemu-devel] [PATCH 1/3] Start moving migration code into a migration directory

2014-10-16 Thread Juan Quintela
"Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > The migration code now occupies a fair chunk of the top level .c > files, it seems time to give it it's own directory. > > I've not touched: >arch_init.c - that's mostly RAM migration but has a few random other >

Re: [Qemu-devel] [PATCH 1/3] Start moving migration code into a migration directory

2014-10-16 Thread Juan Quintela
"Dr. David Alan Gilbert (git)" wrote: G> From: "Dr. David Alan Gilbert" > > The migration code now occupies a fair chunk of the top level .c > files, it seems time to give it it's own directory. > > I've not touched: >arch_init.c - that's mostly RAM migration but has a few random other >

[Qemu-devel] [PATCH 1/3] Start moving migration code into a migration directory

2014-10-16 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" The migration code now occupies a fair chunk of the top level .c files, it seems time to give it it's own directory. I've not touched: arch_init.c - that's mostly RAM migration but has a few random other bits savevm.c- because it's built