Re: [Qemu-devel] [PATCH 1/2] s390x/migration: use zero flag parameter

2017-11-22 Thread Christian Borntraeger
On 11/22/2017 03:43 PM, Cornelia Huck wrote: > On Wed, 22 Nov 2017 15:26:26 +0100 > Christian Borntraeger wrote: > >> valgrind pointed out that we call KVM_S390_GET_IRQ_STATE with an >> undefined value for flags. Right now this is unused, but we >> better play safe. >> The same is true for SET_

Re: [Qemu-devel] [PATCH 1/2] s390x/migration: use zero flag parameter

2017-11-22 Thread Cornelia Huck
On Wed, 22 Nov 2017 15:37:55 +0100 Thomas Huth wrote: > On 22.11.2017 15:26, Christian Borntraeger wrote: > > valgrind pointed out that we call KVM_S390_GET_IRQ_STATE with an > > undefined value for flags. Right now this is unused, but we > > better play safe. > > The same is true for SET_IRQ_STA

Re: [Qemu-devel] [PATCH 1/2] s390x/migration: use zero flag parameter

2017-11-22 Thread Cornelia Huck
On Wed, 22 Nov 2017 15:26:26 +0100 Christian Borntraeger wrote: > valgrind pointed out that we call KVM_S390_GET_IRQ_STATE with an > undefined value for flags. Right now this is unused, but we > better play safe. > The same is true for SET_IRQ_STATE. While QEMU is now fixed in > that regard, we s

Re: [Qemu-devel] [PATCH 1/2] s390x/migration: use zero flag parameter

2017-11-22 Thread Thomas Huth
On 22.11.2017 15:26, Christian Borntraeger wrote: > valgrind pointed out that we call KVM_S390_GET_IRQ_STATE with an > undefined value for flags. Right now this is unused, but we > better play safe. > The same is true for SET_IRQ_STATE. While QEMU is now fixed in > that regard, we should make sure

[Qemu-devel] [PATCH 1/2] s390x/migration: use zero flag parameter

2017-11-22 Thread Christian Borntraeger
valgrind pointed out that we call KVM_S390_GET_IRQ_STATE with an undefined value for flags. Right now this is unused, but we better play safe. The same is true for SET_IRQ_STATE. While QEMU is now fixed in that regard, we should make sure to not use the flag and pad fields in the kernel. A correspo

Re: [Qemu-devel] [PATCH 1/2] s390x/migration: use zero flag parameter

2017-11-20 Thread Christian Borntraeger
On 11/20/2017 01:57 PM, Cornelia Huck wrote: > On Mon, 20 Nov 2017 13:35:24 +0100 > Christian Borntraeger wrote: > >> valgrind pointed out that we call KVM_S390_GET_IRQ_STATE with an >> undefined value for flags. Right now this is unused, but we >> better play safe. >> >> Signed-off-by: Christi

Re: [Qemu-devel] [PATCH 1/2] s390x/migration: use zero flag parameter

2017-11-20 Thread Christian Borntraeger
On 11/20/2017 02:01 PM, Thomas Huth wrote: > On 20.11.2017 13:35, Christian Borntraeger wrote: >> valgrind pointed out that we call KVM_S390_GET_IRQ_STATE with an >> undefined value for flags. Right now this is unused, but we >> better play safe. >> >> Signed-off-by: Christian Borntraeger >> ---

Re: [Qemu-devel] [PATCH 1/2] s390x/migration: use zero flag parameter

2017-11-20 Thread Thomas Huth
On 20.11.2017 13:35, Christian Borntraeger wrote: > valgrind pointed out that we call KVM_S390_GET_IRQ_STATE with an > undefined value for flags. Right now this is unused, but we > better play safe. > > Signed-off-by: Christian Borntraeger > --- > target/s390x/kvm.c | 8 > 1 file change

Re: [Qemu-devel] [PATCH 1/2] s390x/migration: use zero flag parameter

2017-11-20 Thread Cornelia Huck
On Mon, 20 Nov 2017 13:35:24 +0100 Christian Borntraeger wrote: > valgrind pointed out that we call KVM_S390_GET_IRQ_STATE with an > undefined value for flags. Right now this is unused, but we > better play safe. > > Signed-off-by: Christian Borntraeger > --- > target/s390x/kvm.c | 8

[Qemu-devel] [PATCH 1/2] s390x/migration: use zero flag parameter

2017-11-20 Thread Christian Borntraeger
valgrind pointed out that we call KVM_S390_GET_IRQ_STATE with an undefined value for flags. Right now this is unused, but we better play safe. Signed-off-by: Christian Borntraeger --- target/s390x/kvm.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/target/s390x/kvm.