Re: [Qemu-devel] [PATCH 1/2] pixman: require 0.16.4 as minimum version

2012-12-14 Thread Alexander Graf
On 14.12.2012, at 08:54, Gerd Hoffmann wrote: > Hi, > >>> If you send me a fix for 6e72719e721a40fe1224701ca10edc1caf0cd708 >>> I'll go revert 288fa40736e6eb63132d01aa6dc21ee831b796ae >> >> 6e72719 is perfectly sane, because it brings consistency into the >> file. Now both users of PIXMAN_TY

Re: [Qemu-devel] [PATCH 1/2] pixman: require 0.16.4 as minimum version

2012-12-13 Thread Gerd Hoffmann
Hi, >> If you send me a fix for 6e72719e721a40fe1224701ca10edc1caf0cd708 >> I'll go revert 288fa40736e6eb63132d01aa6dc21ee831b796ae > > 6e72719 is perfectly sane, because it brings consistency into the > file. Now both users of PIXMAN_TYPE_BGRA are guarded by the same > #ifdef. Both users? He

Re: [Qemu-devel] [PATCH 1/2] pixman: require 0.16.4 as minimum version

2012-12-13 Thread Alexander Graf
On 13.12.2012, at 16:30, Gerd Hoffmann wrote: > Hi, > >> 6e72719e721a40fe1224701ca10edc1caf0cd708 > > It's broken, version is wrong, and I told you. > Seems you sneaked it in nevertheless. It's consistent now with the #ifdef 5 lines above the line that the patch does. > >> You had 2 branche

Re: [Qemu-devel] [PATCH 1/2] pixman: require 0.16.4 as minimum version

2012-12-13 Thread Gerd Hoffmann
Hi, > 6e72719e721a40fe1224701ca10edc1caf0cd708 It's broken, version is wrong, and I told you. Seems you sneaked it in nevertheless. > You had 2 branches that were using a new flag, one of which you had > an #ifdef around and one of which you didn't. This is all fixed for > quite a while now :)

Re: [Qemu-devel] [PATCH 1/2] pixman: require 0.16.4 as minimum version

2012-12-13 Thread Alexander Graf
On 13.12.2012, at 15:48, Gerd Hoffmann wrote: > On 12/13/12 15:31, Alexander Graf wrote: >> >> On 10.12.2012, at 13:48, Gerd Hoffmann wrote: >> >>> Lower the bar a bit. 0.16.4 is known-good, and is shipped by >>> debian. Fixes build failures on the debian-based buildbot slaves. >> >> SLES11 s

Re: [Qemu-devel] [PATCH 1/2] pixman: require 0.16.4 as minimum version

2012-12-13 Thread Alexander Graf
On 13.12.2012, at 15:48, Gerd Hoffmann wrote: > On 12/13/12 15:31, Alexander Graf wrote: >> >> On 10.12.2012, at 13:48, Gerd Hoffmann wrote: >> >>> Lower the bar a bit. 0.16.4 is known-good, and is shipped by >>> debian. Fixes build failures on the debian-based buildbot slaves. >> >> SLES11 s

Re: [Qemu-devel] [PATCH 1/2] pixman: require 0.16.4 as minimum version

2012-12-13 Thread Gerd Hoffmann
On 12/13/12 15:31, Alexander Graf wrote: > > On 10.12.2012, at 13:48, Gerd Hoffmann wrote: > >> Lower the bar a bit. 0.16.4 is known-good, and is shipped by >> debian. Fixes build failures on the debian-based buildbot slaves. > > SLES11 ships 0.16.0 for example. It'd be nice to stay compatible

Re: [Qemu-devel] [PATCH 1/2] pixman: require 0.16.4 as minimum version

2012-12-13 Thread Alexander Graf
On 10.12.2012, at 13:48, Gerd Hoffmann wrote: > Lower the bar a bit. 0.16.4 is known-good, and is shipped by debian. > Fixes build failures on the debian-based buildbot slaves. SLES11 ships 0.16.0 for example. It'd be nice to stay compatible there. What exactly is the compatibility bar? The fa

[Qemu-devel] [PATCH 1/2] pixman: require 0.16.4 as minimum version

2012-12-10 Thread Gerd Hoffmann
Lower the bar a bit. 0.16.4 is known-good, and is shipped by debian. Fixes build failures on the debian-based buildbot slaves. Signed-off-by: Gerd Hoffmann --- configure |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/configure b/configure index e5aedef..a4e62c4 1007