On 13.12.2012, at 15:48, Gerd Hoffmann wrote: > On 12/13/12 15:31, Alexander Graf wrote: >> >> On 10.12.2012, at 13:48, Gerd Hoffmann wrote: >> >>> Lower the bar a bit. 0.16.4 is known-good, and is shipped by >>> debian. Fixes build failures on the debian-based buildbot slaves. >> >> SLES11 ships 0.16.0 for example. It'd be nice to stay compatible >> there. > > If 0.16.0 is known good we can pick that one. > >> What exactly is the compatibility bar? The fact that it compiles? >> Without the configure check it's compiling just fine on 0.12.0 >> (openSUSE 11.1) here. > > Hmm, /me saw reports of *not* building with 0.12.0, which was the > reason to add this in the first place ...
So basically it boils down to support for PIXMAN_TYPE_BGRA. How about we just check for that one instead rather than the version number? Also, it'd be very consistent if the #ifdefery in qemu-pixman.c gets removed if that's the whole purpose of the configure check. Alex
