Re: [Qemu-devel] [PATCH 1/2] net: netmap: Fix compilation issue

2015-11-06 Thread Markus Armbruster
Vincenzo Maffione writes: > 2015-11-05 16:01 GMT+01:00 Eric Blake : >> On 11/05/2015 07:52 AM, Vincenzo Maffione wrote: >>> No worries. >>> >>> It needs --enable-netmap (default is --disable-netmap on linux), and >>> --extra-cflags=-I/path/to/netmap/sys for netmap API headers. >>> >>> (netmap cod

Re: [Qemu-devel] [PATCH 1/2] net: netmap: Fix compilation issue

2015-11-05 Thread Vincenzo Maffione
2015-11-05 16:01 GMT+01:00 Eric Blake : > On 11/05/2015 07:52 AM, Vincenzo Maffione wrote: >> No worries. >> >> It needs --enable-netmap (default is --disable-netmap on linux), and >> --extra-cflags=-I/path/to/netmap/sys for netmap API headers. >> >> (netmap code is avaliable here https://github.co

Re: [Qemu-devel] [PATCH 1/2] net: netmap: Fix compilation issue

2015-11-05 Thread Eric Blake
On 11/05/2015 07:52 AM, Vincenzo Maffione wrote: > No worries. > > It needs --enable-netmap (default is --disable-netmap on linux), and > --extra-cflags=-I/path/to/netmap/sys for netmap API headers. > > (netmap code is avaliable here https://github.com/luigirizzo/netmap) Default-off tends to bit

Re: [Qemu-devel] [PATCH 1/2] net: netmap: Fix compilation issue

2015-11-05 Thread Vincenzo Maffione
No worries. It needs --enable-netmap (default is --disable-netmap on linux), and --extra-cflags=-I/path/to/netmap/sys for netmap API headers. (netmap code is avaliable here https://github.com/luigirizzo/netmap) 2015-11-05 15:46 GMT+01:00 Eric Blake : > On 11/05/2015 06:01 AM, Markus Armbruster w

Re: [Qemu-devel] [PATCH 1/2] net: netmap: Fix compilation issue

2015-11-05 Thread Eric Blake
On 11/05/2015 06:01 AM, Markus Armbruster wrote: > Vincenzo Maffione writes: > >> Reorganization of struct NetClientOptions caused a compilation failure >> of the netmap backend. This patch fixes the issue by properly accessing the >> union field. >> >> Signed-off-by: Vincenzo Maffione >> --- >>

Re: [Qemu-devel] [PATCH 1/2] net: netmap: Fix compilation issue

2015-11-05 Thread Vincenzo Maffione
Sure, no problems. I was looking for that commit, but using git blame didn't work, since there the data structure seems to be part of autogenerated code. 2015-11-05 14:01 GMT+01:00 Markus Armbruster : > Vincenzo Maffione writes: > >> Reorganization of struct NetClientOptions caused a compilation

Re: [Qemu-devel] [PATCH 1/2] net: netmap: Fix compilation issue

2015-11-05 Thread Markus Armbruster
Vincenzo Maffione writes: > Reorganization of struct NetClientOptions caused a compilation failure > of the netmap backend. This patch fixes the issue by properly accessing the > union field. > > Signed-off-by: Vincenzo Maffione > --- > net/netmap.c | 2 +- > 1 file changed, 1 insertion(+), 1 d

[Qemu-devel] [PATCH 1/2] net: netmap: Fix compilation issue

2015-11-05 Thread Vincenzo Maffione
Reorganization of struct NetClientOptions caused a compilation failure of the netmap backend. This patch fixes the issue by properly accessing the union field. Signed-off-by: Vincenzo Maffione --- net/netmap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/netmap.c b/net