No worries. It needs --enable-netmap (default is --disable-netmap on linux), and --extra-cflags=-I/path/to/netmap/sys for netmap API headers.
(netmap code is avaliable here https://github.com/luigirizzo/netmap) 2015-11-05 15:46 GMT+01:00 Eric Blake <ebl...@redhat.com>: > On 11/05/2015 06:01 AM, Markus Armbruster wrote: >> Vincenzo Maffione <v.maffi...@gmail.com> writes: >> >>> Reorganization of struct NetClientOptions caused a compilation failure >>> of the netmap backend. This patch fixes the issue by properly accessing the >>> union field. >>> >>> Signed-off-by: Vincenzo Maffione <v.maffi...@gmail.com> >>> --- >>> net/netmap.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/net/netmap.c b/net/netmap.c >>> index 508b829..4197a9c 100644 >>> --- a/net/netmap.c >>> +++ b/net/netmap.c >>> @@ -439,7 +439,7 @@ int net_init_netmap(const NetClientOptions *opts, >>> const char *name, NetClientState *peer, Error **errp) >>> { >>> /* FIXME error_setg(errp, ...) on failure */ >>> - const NetdevNetmapOptions *netmap_opts = opts->netmap; >>> + const NetdevNetmapOptions *netmap_opts = opts->u.netmap; >>> NetClientState *nc; >>> NetmapPriv me; >>> NetmapState *s; >> >> Broken in commit e4ba22b. Recommend to point to that in the commit >> message. Thanks for cleaning up the mess we made there! > > My fault for not compiling netmap code. Does it need specific configure > options? > >> >> Reviewed-by: Markus Armbruster <arm...@redhat.com> >> > > Reviewed-by: Eric Blake <ebl...@redhat.com> > > -- > Eric Blake eblake redhat com +1-919-301-3266 > Libvirt virtualization library http://libvirt.org > -- Vincenzo Maffione
