Re: [Qemu-devel] [PATCH 1/2] QMP: Introduce commands doc

2010-05-18 Thread Luiz Capitulino
On Tue, 18 May 2010 11:51:26 +0200 Markus Armbruster wrote: > Anthony Liguori writes: > > > On 05/15/2010 01:19 AM, Avi Kivity wrote: > >> On 05/15/2010 01:54 AM, Luiz Capitulino wrote: > >>> On Fri, 14 May 2010 19:03:36 +0200 > >>> Markus Armbruster wrote: > >>> > > What about PCI domains

Re: [Qemu-devel] [PATCH 1/2] QMP: Introduce commands doc

2010-05-18 Thread Markus Armbruster
Anthony Liguori writes: > On 05/15/2010 01:19 AM, Avi Kivity wrote: >> On 05/15/2010 01:54 AM, Luiz Capitulino wrote: >>> On Fri, 14 May 2010 19:03:36 +0200 >>> Markus Armbruster wrote: >>> > What about PCI domains? Good point. Better to provide for them neatly now, instead of kludging

Re: [Qemu-devel] [PATCH 1/2] QMP: Introduce commands doc

2010-05-18 Thread Avi Kivity
On 05/17/2010 10:21 PM, Gerd Hoffmann wrote: Dunno. Gerd, what do you think? There is a PCIDevice for each function. PCIDevice->devfn (aka addr property) contains slot+function. So hw/pci.c can figure which device functions belong to the same slot. The pci hotplug code might need some f

Re: [Qemu-devel] [PATCH 1/2] QMP: Introduce commands doc

2010-05-17 Thread Gerd Hoffmann
Hi, IMO, that's a serious bug. A slot is a user visible entity, both in that devices can only be hotplugged only as slots, not functions, and to determine the maximum number of devices you can add. If the user knows about it, qemu should too. We can easily represent a slot/device as a qbus wi

Re: [Qemu-devel] [PATCH 1/2] QMP: Introduce commands doc

2010-05-17 Thread Avi Kivity
On 05/17/2010 09:10 PM, Anthony Liguori wrote: The protocol must be forward looking, or we will need endless fixes for it. But we can always add a domain property to extend the address (with a default domain of 0). That's what I meant by endless fixes. Each one is reasonable by itself,

Re: [Qemu-devel] [PATCH 1/2] QMP: Introduce commands doc

2010-05-17 Thread Anthony Liguori
On 05/15/2010 01:19 AM, Avi Kivity wrote: On 05/15/2010 01:54 AM, Luiz Capitulino wrote: On Fri, 14 May 2010 19:03:36 +0200 Markus Armbruster wrote: What about PCI domains? Good point. Better to provide for them neatly now, instead of kludging them in later. When I did this conversion I a

Re: [Qemu-devel] [PATCH 1/2] QMP: Introduce commands doc

2010-05-17 Thread Anthony Liguori
On 05/17/2010 06:19 AM, Markus Armbruster wrote: Avi Kivity writes: On 05/17/2010 11:27 AM, Markus Armbruster wrote: A slot is the hotpluggable entity. Open your computer and you can actually see them. QEMU doesn't really know that. How can

Re: [Qemu-devel] [PATCH 1/2] QMP: Introduce commands doc

2010-05-17 Thread Markus Armbruster
Avi Kivity writes: > On 05/17/2010 11:27 AM, Markus Armbruster wrote: >> >> > A slot is the hotpluggable entity. Open your computer and you can > actually see them. > > QEMU doesn't really know that. >>> How can that be? Do we signal hotplug

Re: [Qemu-devel] [PATCH 1/2] QMP: Introduce commands doc

2010-05-17 Thread Avi Kivity
On 05/17/2010 11:27 AM, Markus Armbruster wrote: A slot is the hotpluggable entity. Open your computer and you can actually see them. QEMU doesn't really know that. How can that be? Do we signal hotplug notifications to a function or to a slot? Can we hotplug a sing

Re: [Qemu-devel] [PATCH 1/2] QMP: Introduce commands doc

2010-05-17 Thread Markus Armbruster
Avi Kivity writes: > On 05/15/2010 01:54 AM, Luiz Capitulino wrote: >> On Fri, 14 May 2010 19:03:36 +0200 >> Markus Armbruster wrote: >> >> What about PCI domains? >>> Good point. Better to provide for them neatly now, instead of kludging >>> them in later. >>> >>

Re: [Qemu-devel] [PATCH 1/2] QMP: Introduce commands doc

2010-05-17 Thread Markus Armbruster
Avi Kivity writes: > On 05/14/2010 08:03 PM, Markus Armbruster wrote: >> Avi Kivity writes: >> >> >>> On 05/14/2010 11:50 AM, Markus Armbruster wrote: [...] We have a list of buses, each containing a list of device functions. Not sure the additional level of nesting you propose buy

Re: [Qemu-devel] [PATCH 1/2] QMP: Introduce commands doc

2010-05-14 Thread Avi Kivity
On 05/15/2010 01:54 AM, Luiz Capitulino wrote: On Fri, 14 May 2010 19:03:36 +0200 Markus Armbruster wrote: What about PCI domains? Good point. Better to provide for them neatly now, instead of kludging them in later. When I did this conversion I asked Micheal for help wi

Re: [Qemu-devel] [PATCH 1/2] QMP: Introduce commands doc

2010-05-14 Thread Luiz Capitulino
On Fri, 14 May 2010 19:03:36 +0200 Markus Armbruster wrote: > > What about PCI domains? > > Good point. Better to provide for them neatly now, instead of kludging > them in later. When I did this conversion I asked Micheal for help with that and he said QEMU doesn't support PCI domains.

Re: [Qemu-devel] [PATCH 1/2] QMP: Introduce commands doc

2010-05-14 Thread Avi Kivity
On 05/14/2010 08:03 PM, Markus Armbruster wrote: Avi Kivity writes: On 05/14/2010 11:50 AM, Markus Armbruster wrote: + +{ "execute": "migrate_set_speed", "arguments": { "value": 1024 } } Oh, we do have more. Please document the units for this value (bits per

Re: [Qemu-devel] [PATCH 1/2] QMP: Introduce commands doc

2010-05-14 Thread Markus Armbruster
Avi Kivity writes: > On 05/14/2010 11:50 AM, Markus Armbruster wrote: >> + +{ "execute": "migrate_set_speed", "arguments": { "value": 1024 } } >>> Oh, we do have more. >>> >>> Please document the units for this value (bits per second)? >>> >> bytes per second? >>

Re: [Qemu-devel] [PATCH 1/2] QMP: Introduce commands doc

2010-05-14 Thread Markus Armbruster
Avi Kivity writes: > On 05/14/2010 11:33 AM, Markus Armbruster wrote: >> >> And we absolutely need to make use of that license to improve stuff. >> Premature stability leads to stable crap. Having to get everything >> right the first time is just too hard for mortals. >> > > If that is the w

Re: [Qemu-devel] [PATCH 1/2] QMP: Introduce commands doc

2010-05-14 Thread Avi Kivity
On 05/14/2010 11:33 AM, Markus Armbruster wrote: And we absolutely need to make use of that license to improve stuff. Premature stability leads to stable crap. Having to get everything right the first time is just too hard for mortals. If that is the way we go (and I'm not sure what's the

Re: [Qemu-devel] [PATCH 1/2] QMP: Introduce commands doc

2010-05-14 Thread Avi Kivity
On 05/14/2010 11:50 AM, Markus Armbruster wrote: + +{ "execute": "migrate_set_speed", "arguments": { "value": 1024 } } Oh, we do have more. Please document the units for this value (bits per second)? bytes per second? Bandwidth is typically measured in bits per second.

Re: [Qemu-devel] [PATCH 1/2] QMP: Introduce commands doc

2010-05-14 Thread Luiz Capitulino
On Fri, 14 May 2010 10:39:29 +0200 Markus Armbruster wrote: > Luiz Capitulino writes: > > > On Thu, 13 May 2010 16:48:13 +0300 > > Avi Kivity wrote: > > > >> On 05/05/2010 10:11 PM, Luiz Capitulino wrote: > >> > One of the most important missing feature in QMP today is its > >> > supported com

Re: [Qemu-devel] [PATCH 1/2] QMP: Introduce commands doc

2010-05-14 Thread Kevin Wolf
Am 12.05.2010 23:17, schrieb Luiz Capitulino: > On Wed, 12 May 2010 18:48:38 +0200 > Markus Armbruster wrote: > >>> +query-block >>> +--- >>> + >>> +Show the block devices. >>> + >>> +Each block device information is stored in a json-object and the returned >>> value >>> +is a json-array

Re: [Qemu-devel] [PATCH 1/2] QMP: Introduce commands doc

2010-05-14 Thread Markus Armbruster
Avi, thanks a lot for reviewing this!

Re: [Qemu-devel] [PATCH 1/2] QMP: Introduce commands doc

2010-05-14 Thread Markus Armbruster
Avi Kivity writes: > On 05/05/2010 10:11 PM, Luiz Capitulino wrote: >> One of the most important missing feature in QMP today is its >> supported commands documentation. >> >> The plan is to make it part of self-description support, however >> self-description is a big task we have been postponin

Re: [Qemu-devel] [PATCH 1/2] QMP: Introduce commands doc

2010-05-14 Thread Markus Armbruster
Luiz Capitulino writes: > On Thu, 13 May 2010 16:48:13 +0300 > Avi Kivity wrote: > >> On 05/05/2010 10:11 PM, Luiz Capitulino wrote: >> > One of the most important missing feature in QMP today is its >> > supported commands documentation. >> > >> > The plan is to make it part of self-description

Re: [Qemu-devel] [PATCH 1/2] QMP: Introduce commands doc

2010-05-14 Thread Markus Armbruster
Luiz Capitulino writes: > On Thu, 13 May 2010 19:23:11 +0300 > Avi Kivity wrote: > >> On 05/13/2010 06:01 PM, Daniel P. Berrange wrote: >> > >> >> Yes, we do and it's used by libvirt iirc. >> >> >> > This command has been in QEMU for quite a long time now (0.9.x IIRC). >> > >> >> It

Re: [Qemu-devel] [PATCH 1/2] QMP: Introduce commands doc

2010-05-13 Thread Luiz Capitulino
On Thu, 13 May 2010 19:23:11 +0300 Avi Kivity wrote: > On 05/13/2010 06:01 PM, Daniel P. Berrange wrote: > > > >> Yes, we do and it's used by libvirt iirc. > >> > > This command has been in QEMU for quite a long time now (0.9.x IIRC). > > > > It wasn't in QMP until 0.12. We shouldn'

Re: [Qemu-devel] [PATCH 1/2] QMP: Introduce commands doc

2010-05-13 Thread Avi Kivity
On 05/13/2010 06:01 PM, Daniel P. Berrange wrote: Yes, we do and it's used by libvirt iirc. This command has been in QEMU for quite a long time now (0.9.x IIRC). It wasn't in QMP until 0.12. We shouldn't have put it there in that form. IIRC, Gerd's SPICE proposal should includ

Re: [Qemu-devel] [PATCH 1/2] QMP: Introduce commands doc

2010-05-13 Thread Avi Kivity
On 05/13/2010 05:55 PM, Luiz Capitulino wrote: +change +-- + +Change a removable medium or VNC configuration. This is sad. Would anyone write a C function with a similar description? I wouldn't, but someone did for qemu. Do we have this in 0.12? If not we can cha

Re: [Qemu-devel] [PATCH 1/2] QMP: Introduce commands doc

2010-05-13 Thread Daniel P. Berrange
On Thu, May 13, 2010 at 11:55:24AM -0300, Luiz Capitulino wrote: > On Thu, 13 May 2010 16:48:13 +0300 > Avi Kivity wrote: > > > > > +change > > > +-- > > > + > > > +Change a removable medium or VNC configuration. > > > > > > > This is sad. Would anyone write a C function with a similar

Re: [Qemu-devel] [PATCH 1/2] QMP: Introduce commands doc

2010-05-13 Thread Luiz Capitulino
On Thu, 13 May 2010 16:48:13 +0300 Avi Kivity wrote: > On 05/05/2010 10:11 PM, Luiz Capitulino wrote: > > One of the most important missing feature in QMP today is its > > supported commands documentation. > > > > The plan is to make it part of self-description support, however > > self-descripti

Re: [Qemu-devel] [PATCH 1/2] QMP: Introduce commands doc

2010-05-13 Thread Avi Kivity
On 05/05/2010 10:11 PM, Luiz Capitulino wrote: One of the most important missing feature in QMP today is its supported commands documentation. The plan is to make it part of self-description support, however self-description is a big task we have been postponing for a long time now and still don

Re: [Qemu-devel] [PATCH 1/2] QMP: Introduce commands doc

2010-05-13 Thread Luiz Capitulino
On Thu, 13 May 2010 09:01:21 +0200 Markus Armbruster wrote: > Luiz Capitulino writes: > > > On Wed, 12 May 2010 18:48:38 +0200 > > Markus Armbruster wrote: > > > >> > +query-block > >> > +--- > >> > + > >> > +Show the block devices. > >> > + > >> > +Each block device information is sto

Re: [Qemu-devel] [PATCH 1/2] QMP: Introduce commands doc

2010-05-13 Thread Markus Armbruster
Luiz Capitulino writes: > On Wed, 12 May 2010 18:48:38 +0200 > Markus Armbruster wrote: > >> > +query-block >> > +--- >> > + >> > +Show the block devices. >> > + >> > +Each block device information is stored in a json-object and the returned >> > value >> > +is a json-array of all devic

Re: [Qemu-devel] [PATCH 1/2] QMP: Introduce commands doc

2010-05-12 Thread Luiz Capitulino
On Wed, 12 May 2010 18:48:38 +0200 Markus Armbruster wrote: > > +query-block > > +--- > > + > > +Show the block devices. > > + > > +Each block device information is stored in a json-object and the returned > > value > > +is a json-array of all devices. > > + > > +Each json-object contain

Re: [Qemu-devel] [PATCH 1/2] QMP: Introduce commands doc

2010-05-12 Thread Markus Armbruster
Luiz Capitulino writes: > One of the most important missing feature in QMP today is its > supported commands documentation. > > The plan is to make it part of self-description support, however > self-description is a big task we have been postponing for a > long time now and still don't know when

[Qemu-devel] [PATCH 1/2] QMP: Introduce commands doc

2010-05-05 Thread Luiz Capitulino
One of the most important missing feature in QMP today is its supported commands documentation. The plan is to make it part of self-description support, however self-description is a big task we have been postponing for a long time now and still don't know when it's going to be done. In order not

Re: [Qemu-devel] [PATCH 1/2] QMP: Introduce commands doc

2010-05-05 Thread Luiz Capitulino
On Mon, 03 May 2010 18:24:11 +0200 Markus Armbruster wrote: > > + > > +Example: > > + > > +{ "execute": "migrate", "arguments": { "uri": "tcp:0:4446" } } > > + > > +Notes: > > + > > +(1) The 'query-migrate' command should be used to check migration's > > progress > > +and final result (this

Re: [Qemu-devel] [PATCH 1/2] QMP: Introduce commands doc

2010-05-03 Thread Markus Armbruster
Luiz Capitulino writes: > One of the most important missing feature in QMP today is its > supported command documentation. > > The plan is to make it part of self-description support, however > self-description is a big task we have been postponing for a > long time now and still don't know when

[Qemu-devel] [PATCH 1/2] QMP: Introduce commands doc

2010-04-30 Thread Luiz Capitulino
One of the most important missing feature in QMP today is its supported command documentation. The plan is to make it part of self-description support, however self-description is a big task we have been postponing for a long time now and still don't know when it's going to be done. In order not