On Tue, 18 May 2010 11:51:26 +0200 Markus Armbruster <arm...@redhat.com> wrote:
> Anthony Liguori <anth...@codemonkey.ws> writes: > > > On 05/15/2010 01:19 AM, Avi Kivity wrote: > >> On 05/15/2010 01:54 AM, Luiz Capitulino wrote: > >>> On Fri, 14 May 2010 19:03:36 +0200 > >>> Markus Armbruster<arm...@redhat.com> wrote: > >>> > >>>>> What about PCI domains? > >>>> Good point. Better to provide for them neatly now, instead of kludging > >>>> them in later. > >>> When I did this conversion I asked Micheal for help with that and > >>> he said > >>> QEMU doesn't support PCI domains. > >> > >> That's very different from "will never support pci domains". > >> > >> The protocol must be forward looking, or we will need endless fixes > >> for it. > > > > But we can always add a domain property to extend the address (with a > > default domain of 0). > > Why not add it right away? The plan is to merge the doc and work on all changes suggested by Avi (always coordinating with libvirt, of course). Although query-pci is not used there. > Note that if we'd decide to adopt Avi's suggestion to make this "a > nested object (list of buses, each containing a list of slots, each > containing a list of functions)", then we can't easily add domains > later, because that would insert a level of nesting near the top. Right.