Re: [Qemu-devel] [PATCH 1/1] block migration: fix return value mismatch

2014-11-24 Thread Dr. David Alan Gilbert
* Gary R Hook (grhookatw...@gmail.com) wrote: > Stefan Hajnoczi writes: > > > On Wed, Nov 12, 2014 at 06:48:18PM +, Gary Hook wrote: > >> -return qemu_ftell(f) - last_ftell; > >> +delta_ftell = qemu_ftell(f) - last_ftell; > >> +return( (delta_ftell > 0) ? 1 : (delta_ftell < 0) ? -

Re: [Qemu-devel] [PATCH 1/1] block migration: fix return value mismatch

2014-11-21 Thread Gary R Hook
Stefan Hajnoczi writes: > On Wed, Nov 12, 2014 at 06:48:18PM +, Gary Hook wrote: >> -return qemu_ftell(f) - last_ftell; >> +delta_ftell = qemu_ftell(f) - last_ftell; >> +return( (delta_ftell > 0) ? 1 : (delta_ftell < 0) ? -1 : 0 ); > > Good find! > > Please don't nest the ternary

Re: [Qemu-devel] [PATCH 1/1] block migration: fix return value mismatch

2014-11-13 Thread Gary R Hook
Stefan Hajnoczi November 13, 2014 at 12:55 PM One more thing about email configuration: the character set encoding of your emails seems to be incorrect. GMail is rendering a superscript 1 (like "to the power of one") when you wanted a single quote: https://en.wikip

Re: [Qemu-devel] [PATCH 1/1] block migration: fix return value mismatch

2014-11-13 Thread Stefan Hajnoczi
On Thu, Nov 13, 2014 at 5:32 PM, Gary Hook wrote: > On 11/13/14, 11:03 AM, "Eric Blake" wrote: > >>On 11/13/2014 09:44 AM, Gary Hook wrote: >> >>[metacomment] >> >>> On 11/13/14, 6:46 AM, "Markus Armbruster" >>>mailto:arm...@redhat.com>> wrote: >>> >>> Stefan Hajnoczi mailto:stefa...@gmail.com>>

Re: [Qemu-devel] [PATCH 1/1] block migration: fix return value mismatch

2014-11-13 Thread Gary Hook
On 11/13/14, 11:03 AM, "Eric Blake" wrote: >On 11/13/2014 09:44 AM, Gary Hook wrote: > >[metacomment] > >> On 11/13/14, 6:46 AM, "Markus Armbruster" >>mailto:arm...@redhat.com>> wrote: >> >> Stefan Hajnoczi mailto:stefa...@gmail.com>> writes: >> >> On Wed, Nov 12, 2014 at 06:48:18PM +, Ga

Re: [Qemu-devel] [PATCH 1/1] block migration: fix return value mismatch

2014-11-13 Thread Eric Blake
On 11/13/2014 09:44 AM, Gary Hook wrote: [metacomment] > On 11/13/14, 6:46 AM, "Markus Armbruster" > mailto:arm...@redhat.com>> wrote: > > Stefan Hajnoczi mailto:stefa...@gmail.com>> writes: > > On Wed, Nov 12, 2014 at 06:48:18PM +, Gary Hook wrote: Your quoting style leaves a lot to be d

Re: [Qemu-devel] [PATCH 1/1] block migration: fix return value mismatch

2014-11-13 Thread Gary Hook
On 11/13/14, 6:46 AM, "Markus Armbruster" mailto:arm...@redhat.com>> wrote: Stefan Hajnoczi mailto:stefa...@gmail.com>> writes: On Wed, Nov 12, 2014 at 06:48:18PM +, Gary Hook wrote: -return qemu_ftell(f) - last_ftell; +delta_ftell = qemu_ftell(f) - last_ftell; +return( (delta_ft

Re: [Qemu-devel] [PATCH 1/1] block migration: fix return value mismatch

2014-11-13 Thread Gary Hook
On 11/13/14, 5:20 AM, "Stefan Hajnoczi" mailto:stefa...@gmail.com>> wrote: On Wed, Nov 12, 2014 at 06:48:18PM +, Gary Hook wrote: -return qemu_ftell(f) - last_ftell; +delta_ftell = qemu_ftell(f) - last_ftell; +return( (delta_ftell > 0) ? 1 : (delta_ftell < 0) ? -1 : 0 ); Good fin

Re: [Qemu-devel] [PATCH 1/1] block migration: fix return value mismatch

2014-11-13 Thread Markus Armbruster
Stefan Hajnoczi writes: > On Wed, Nov 12, 2014 at 06:48:18PM +, Gary Hook wrote: >> -return qemu_ftell(f) - last_ftell; >> +delta_ftell = qemu_ftell(f) - last_ftell; >> +return( (delta_ftell > 0) ? 1 : (delta_ftell < 0) ? -1 : 0 ); > > Good find! > > Please don't nest the ternary

Re: [Qemu-devel] [PATCH 1/1] block migration: fix return value mismatch

2014-11-13 Thread Stefan Hajnoczi
On Wed, Nov 12, 2014 at 06:48:18PM +, Gary Hook wrote: > -return qemu_ftell(f) - last_ftell; > +delta_ftell = qemu_ftell(f) - last_ftell; > +return( (delta_ftell > 0) ? 1 : (delta_ftell < 0) ? -1 : 0 ); Good find! Please don't nest the ternary operator, it is hard to read. if (de

Re: [Qemu-devel] [PATCH 1/1] block migration: fix return value mismatch

2014-11-12 Thread Markus Armbruster
Eric Blake writes: > On 11/12/2014 11:48 AM, Gary Hook wrote: >> The function uses a ternary return value (<, >, == 0) defined as an >> int. The code in in this function uses int64_t types to collect >> ftell() return values and use their difference as the return >> value. Unfortunately, narrowin

Re: [Qemu-devel] [PATCH 1/1] block migration: fix return value mismatch

2014-11-12 Thread Eric Blake
On 11/12/2014 11:48 AM, Gary Hook wrote: > The function uses a ternary return value (<, >, == 0) defined as an int. The > code in in this function uses int64_t types to collect ftell() return values > and use their difference as the return value. Unfortunately, narrowing of > integer types resul

[Qemu-devel] [PATCH 1/1] block migration: fix return value mismatch

2014-11-12 Thread Gary Hook
The function uses a ternary return value (<, >, == 0) defined as an int. The code in in this function uses int64_t types to collect ftell() return values and use their difference as the return value. Unfortunately, narrowing of integer types results in the disposal of the left-most bits that won