On 11/12/2014 11:48 AM, Gary Hook wrote: > The function uses a ternary return value (<, >, == 0) defined as an int. The > code in in this function uses int64_t types to collect ftell() return values > and use their difference as the return value. Unfortunately, narrowing of > integer types results in the disposal of the left-most bits that won't fit in > the target type. Here, for values larger than 2GB, the resulting value will > be randomly negative or positive, based on total number of blocks. The patch > ensures that only +1, -1, or 0 are returned to properly report status. >
Please wrap commit messages at around 70 characters ('git log' likes to
indent, and people still like to use 80-column windows to read 'git log').
>
>
>
> diff -u -r a/block-migration.c b/block-migration.c
>
Your patch is missing a 'Signed-off-by' line, which is essential to
getting it applied. It is also missing the typical '---' separator
between commit message and patch body.
> --- a/block-migration.c 2014-04-17 08:30:59.000000000 -0500
>
> +++ b/block-migration.c 2014-11-10 12:39:10.727431187 -0600
>
> @@ -628,6 +628,7 @@
Your patch is mal-formed, with too many blank lines inserted by your
mailer. We generally request that you use 'git send-email' rather than
manually pasting your patch into an email, since git is more likely to
send a correctly-formed message.
Also, it appears that you sent a 0/1 cover letter, but forgot to put
this message as In-Reply-To that message. For a single patch, no cover
letter is necessary; but for a patch series, it is important to properly
thread your emails.
More details on proper patch submission can be found here:
http://wiki.qemu.org/Contribute/SubmitAPatch
At any rate, the patch looks reasonable, so please resend it as v2 with
your Signed-off-by.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
