Re: [Qemu-devel] [PATCH 09/19] sockets: Chardev open error reporting, sockets part

2012-09-05 Thread Luiz Capitulino
On Wed, 5 Sep 2012 10:19:22 +0800 Amos Kong wrote: > On Thu, Aug 30, 2012 at 12:04 AM, Amos Kong wrote: > > > On Wed, Aug 29, 2012 at 11:15 PM, Amos Kong wrote: > > > On Thu, Feb 23, 2012 at 4:15 PM, Markus Armbruster > > wrote: > > >> > > >> Anthony Liguori writes: > > >> > > >> > On 02/15/

Re: [Qemu-devel] [PATCH 09/19] sockets: Chardev open error reporting, sockets part

2012-09-04 Thread Amos Kong
On Thu, Aug 30, 2012 at 12:04 AM, Amos Kong wrote: > On Wed, Aug 29, 2012 at 11:15 PM, Amos Kong wrote: > > On Thu, Feb 23, 2012 at 4:15 PM, Markus Armbruster > wrote: > >> > >> Anthony Liguori writes: > >> > >> > On 02/15/2012 07:33 AM, Markus Armbruster wrote: > >> >> Anthony Liguori writes

Re: [Qemu-devel] [PATCH 09/19] sockets: Chardev open error reporting, sockets part

2012-08-29 Thread Amos Kong
On Wed, Aug 29, 2012 at 11:15 PM, Amos Kong wrote: > On Thu, Feb 23, 2012 at 4:15 PM, Markus Armbruster wrote: >> >> Anthony Liguori writes: >> >> > On 02/15/2012 07:33 AM, Markus Armbruster wrote: >> >> Anthony Liguori writes: >> >> >> >>> On 02/14/2012 11:24 AM, Markus Armbruster wrote: >> >>

Re: [Qemu-devel] [PATCH 09/19] sockets: Chardev open error reporting, sockets part

2012-08-29 Thread Amos Kong
On Thu, Feb 23, 2012 at 4:15 PM, Markus Armbruster wrote: > > Anthony Liguori writes: > > > On 02/15/2012 07:33 AM, Markus Armbruster wrote: > >> Anthony Liguori writes: > >> > >>> On 02/14/2012 11:24 AM, Markus Armbruster wrote: > Markus Armbruster writes: > > > Anthony Liguori

Re: [Qemu-devel] [PATCH 09/19] sockets: Chardev open error reporting, sockets part

2012-02-23 Thread Markus Armbruster
Anthony Liguori writes: > On 02/15/2012 07:33 AM, Markus Armbruster wrote: >> Anthony Liguori writes: >> >>> On 02/14/2012 11:24 AM, Markus Armbruster wrote: Markus Armbruster writes: > Anthony Liguori writes: [Anthony asking for error_set() instead of error_report()...] >

Re: [Qemu-devel] [PATCH 09/19] sockets: Chardev open error reporting, sockets part

2012-02-22 Thread Anthony Liguori
On 02/15/2012 07:33 AM, Markus Armbruster wrote: Anthony Liguori writes: On 02/14/2012 11:24 AM, Markus Armbruster wrote: Markus Armbruster writes: Anthony Liguori writes: [Anthony asking for error_set() instead of error_report()...] Basically, same thing here and the remaining functi

Re: [Qemu-devel] [PATCH 09/19] sockets: Chardev open error reporting, sockets part

2012-02-15 Thread Markus Armbruster
Anthony Liguori writes: > On 02/14/2012 11:24 AM, Markus Armbruster wrote: >> Markus Armbruster writes: >> >>> Anthony Liguori writes: >> [Anthony asking for error_set() instead of error_report()...] Basically, same thing here and the remaining functions. Let's not introduce addition

Re: [Qemu-devel] [PATCH 09/19] sockets: Chardev open error reporting, sockets part

2012-02-14 Thread Anthony Liguori
On 02/14/2012 11:24 AM, Markus Armbruster wrote: Markus Armbruster writes: Anthony Liguori writes: [Anthony asking for error_set() instead of error_report()...] Basically, same thing here and the remaining functions. Let's not introduce additional uses of error_report(). That said, I imag

Re: [Qemu-devel] [PATCH 09/19] sockets: Chardev open error reporting, sockets part

2012-02-14 Thread Markus Armbruster
Markus Armbruster writes: > Anthony Liguori writes: [Anthony asking for error_set() instead of error_report()...] >> Basically, same thing here and the remaining functions. Let's not >> introduce additional uses of error_report(). >> >> That said, I imagine you don't want to introduce a bunch o

Re: [Qemu-devel] [PATCH 09/19] sockets: Chardev open error reporting, sockets part

2012-02-09 Thread Markus Armbruster
Anthony Liguori writes: > On 02/07/2012 08:09 AM, Markus Armbruster wrote: >> Convert to error_report(). This adds error locations to the messages, >> which is particularly important when the location is buried in a >> configuration file. Moreover, we'll need this when we create a >> monitor co

Re: [Qemu-devel] [PATCH 09/19] sockets: Chardev open error reporting, sockets part

2012-02-07 Thread Anthony Liguori
On 02/07/2012 08:09 AM, Markus Armbruster wrote: Convert to error_report(). This adds error locations to the messages, which is particularly important when the location is buried in a configuration file. Moreover, we'll need this when we create a monitor command to add character devices, so its

[Qemu-devel] [PATCH 09/19] sockets: Chardev open error reporting, sockets part

2012-02-07 Thread Markus Armbruster
Convert to error_report(). This adds error locations to the messages, which is particularly important when the location is buried in a configuration file. Moreover, we'll need this when we create a monitor command to add character devices, so its errors actually appear in the monitor, not stderr.