Markus Armbruster <arm...@redhat.com> writes: > Anthony Liguori <aligu...@us.ibm.com> writes: [Anthony asking for error_set() instead of error_report()...] >> Basically, same thing here and the remaining functions. Let's not >> introduce additional uses of error_report(). >> >> That said, I imagine you don't want to introduce a bunch of error >> types for these different things and that's probably not productive >> anyway. [...] >> So let's compromise and introduce a generic QERR_INTERNAL_ERROR that >> takes a single human readable string as an argument. We can have a >> wrapper for it that also records location information in the error >> object. > > This series goes from stderr to error_report(). That's a relatively > simple step, which makes it relatively easy to review. I'm afraid > moving all the way to error.h in one step wouldn't be as easy. Kevin > suggests to do it in a follow-up series, and I agree. > > Can you point to an existing conversion from error_report() to error.h, > to give us an idea how it's supposed to be done?
Ping?
