Re: [Qemu-devel] [PATCH 05/11] cs4231a: Convert to MemoryRegion.

2011-08-10 Thread Avi Kivity
On 08/11/2011 09:22 AM, Avi Kivity wrote: On 08/11/2011 01:28 AM, Richard Henderson wrote: } }; +static const MemoryRegionOps cs_ioport_ops = { +.read = cs_read, +.write = cs_write, +.impl = { +.min_access_size = 1, +.max_access_size = 1, +} +}; Should

Re: [Qemu-devel] [PATCH 05/11] cs4231a: Convert to MemoryRegion.

2011-08-10 Thread Avi Kivity
On 08/11/2011 01:28 AM, Richard Henderson wrote: } }; +static const MemoryRegionOps cs_ioport_ops = { +.read = cs_read, +.write = cs_write, +.impl = { +.min_access_size = 1, +.max_access_size = 1, +} +}; Should be .valid, not .impl. .impl means the impl

[Qemu-devel] [PATCH 05/11] cs4231a: Convert to MemoryRegion.

2011-08-10 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/cs4231a.c | 38 +++--- 1 files changed, 19 insertions(+), 19 deletions(-) diff --git a/hw/cs4231a.c b/hw/cs4231a.c index 598f032..e16665e 100644 --- a/hw/cs4231a.c +++ b/hw/cs4231a.c @@ -59,6 +59,7 @@ static struct { type