Re: [Qemu-devel] [PATCH 05/10] target-avr: adding AVR interrupt handling

2016-06-04 Thread Michael Rolnik
fixed. On Sun, Jun 5, 2016 at 1:26 AM, Richard Henderson wrote: > On 06/02/2016 01:06 PM, Michael Rolnik wrote: > >> +} else if (env->intsrc != 0) { >> +vector = __builtin_ffs(env->intsrc); >> +} >> > > Use either ffs (no __builtin) or, preferably, ctz32 from qemu/host-utils.h.

Re: [Qemu-devel] [PATCH 05/10] target-avr: adding AVR interrupt handling

2016-06-04 Thread Richard Henderson
On 06/02/2016 01:06 PM, Michael Rolnik wrote: +} else if (env->intsrc != 0) { +vector = __builtin_ffs(env->intsrc); +} Use either ffs (no __builtin) or, preferably, ctz32 from qemu/host-utils.h. +env->pc = base + vector * size; +env->pc = base + vector * size;

[Qemu-devel] [PATCH 05/10] target-avr: adding AVR interrupt handling

2016-06-02 Thread Michael Rolnik
Signed-off-by: Michael Rolnik --- target-avr/helper.c | 64 - 1 file changed, 63 insertions(+), 1 deletion(-) diff --git a/target-avr/helper.c b/target-avr/helper.c index aec37af..ed22b37 100644 --- a/target-avr/helper.c +++ b/target-avr/helper

[Qemu-devel] [PATCH 05/10] target-avr: adding AVR interrupt handling

2016-06-02 Thread Michael Rolnik
Signed-off-by: Michael Rolnik --- target-avr/helper.c | 64 - 1 file changed, 63 insertions(+), 1 deletion(-) diff --git a/target-avr/helper.c b/target-avr/helper.c index aec37af..ed22b37 100644 --- a/target-avr/helper.c +++ b/target-avr/helper