Re: [Qemu-devel] [PATCH 05/10] target-avr: adding AVR interrupt handling

[Richard Henderson]

On 06/02/2016 01:06 PM, Michael Rolnik wrote:

+    } else if (env->intsrc != 0) {
+        vector  = __builtin_ffs(env->intsrc);
+    }

Use either ffs (no __builtin) or, preferably, ctz32 from qemu/host-utils.h.

+        env->pc = base + vector * size;
+        env->pc = base + vector * size;
+        env->pc = base + vector * size;

No point replicating this 3 times.


r~