Re: [Qemu-devel] [PATCH 04/16] scsi: INQUIRY VPD fixes

2010-11-19 Thread Christoph Hellwig
On Thu, Nov 18, 2010 at 03:47:00PM +0100, Hannes Reinecke wrote: > > We should announce and support the block device characterics page > only on block devices, not on CDROMs. And the VPD page 0x83 has > an off-by-one error. Looks good. This code would be a lot cleaner by splitting all vpd emulat

[Qemu-devel] [PATCH 04/16] scsi: INQUIRY VPD fixes

2010-11-18 Thread Hannes Reinecke
We should announce and support the block device characterics page only on block devices, not on CDROMs. And the VPD page 0x83 has an off-by-one error. Signed-off-by: Hannes Reinecke --- hw/scsi-disk.c | 18 ++ 1 files changed, 14 insertions(+), 4 deletions(-) diff --git a/hw/