On Thu, Nov 18, 2010 at 03:47:00PM +0100, Hannes Reinecke wrote: > > We should announce and support the block device characterics page > only on block devices, not on CDROMs. And the VPD page 0x83 has > an off-by-one error.
Looks good. This code would be a lot cleaner by splitting all vpd emulations out into separate helpers, btw.