Re: [Qemu-devel] [PATCH 03/12] hw/pci/pci_host.c: Avoid shifting left into sign bit

2014-03-10 Thread Michael S. Tsirkin
On Mon, Mar 10, 2014 at 07:10:39PM +, Peter Maydell wrote: > Add U suffix to avoid undefined behaviour. > > Signed-off-by: Peter Maydell Reviewed-by: Michael S. Tsirkin > --- > hw/pci/pci_host.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/hw/pci/pci_host.c

Re: [Qemu-devel] [PATCH 03/12] hw/pci/pci_host.c: Avoid shifting left into sign bit

2014-03-10 Thread Michael S. Tsirkin
On Mon, Mar 10, 2014 at 09:03:08PM +0100, Stefan Weil wrote: > Am 10.03.2014 20:10, schrieb Peter Maydell: > > Add U suffix to avoid undefined behaviour. > > > > Signed-off-by: Peter Maydell > > --- > > hw/pci/pci_host.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff -

Re: [Qemu-devel] [PATCH 03/12] hw/pci/pci_host.c: Avoid shifting left into sign bit

2014-03-10 Thread Stefan Weil
Am 10.03.2014 20:10, schrieb Peter Maydell: > Add U suffix to avoid undefined behaviour. > > Signed-off-by: Peter Maydell > --- > hw/pci/pci_host.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/hw/pci/pci_host.c b/hw/pci/pci_host.c > index 77c7d1f..2c17916 100644 >

[Qemu-devel] [PATCH 03/12] hw/pci/pci_host.c: Avoid shifting left into sign bit

2014-03-10 Thread Peter Maydell
Add U suffix to avoid undefined behaviour. Signed-off-by: Peter Maydell --- hw/pci/pci_host.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/pci/pci_host.c b/hw/pci/pci_host.c index 77c7d1f..2c17916 100644 --- a/hw/pci/pci_host.c +++ b/hw/pci/pci_host.c @@ -142,8 +142,9