On 5 September 2017 at 10:35, Philippe Mathieu-Daudé wrote:
> I'm not sure this kind of mistake happens often enough, but it might worth
> add a such test in checkpatch.pl (easier to say than to implement :p)
It doesn't run automatically, but you can run scripts/clean-includes
on your new files t
On 05/08/2017 08:56 PM, Eric Blake wrote:
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/misc/unimp.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/include/hw/misc/unimp.h b/include/hw/misc/unimp.h
index 3462d85836..353ee19abf 100644
--- a/include/hw/misc/unimp.h
+++ b/include/
On 05/09/2017 12:20 PM, Philippe Mathieu-Daudé wrote:
> What about the other include, "hw/sysbus.h"?
> The inlined function create_unimplemented_device() calls
> sysbus_mmio_map_overlap(). Anyone willing to use "hw/misc/unimp.h" will
> get a compilation failure if he does not include "hw/sysbus.h"
Hi Eric,
On 05/08/2017 09:56 PM, Philippe Mathieu-Daudé wrote:
On 05/08/2017 08:56 PM, Eric Blake wrote:
On 05/08/2017 06:39 PM, Philippe Mathieu-Daudé wrote:
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/misc/unimp.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/include/hw/m
On 05/08/2017 08:56 PM, Eric Blake wrote:
On 05/08/2017 06:39 PM, Philippe Mathieu-Daudé wrote:
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/misc/unimp.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/include/hw/misc/unimp.h b/include/hw/misc/unimp.h
index 3462d85836..353ee19ab
On 05/08/2017 06:39 PM, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> include/hw/misc/unimp.h | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/include/hw/misc/unimp.h b/include/hw/misc/unimp.h
> index 3462d85836..353ee19abf 100644
> --- a/include/hw/mis
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/misc/unimp.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/include/hw/misc/unimp.h b/include/hw/misc/unimp.h
index 3462d85836..353ee19abf 100644
--- a/include/hw/misc/unimp.h
+++ b/include/hw/misc/unimp.h
@@ -8,6 +8,9 @@
#ifndef HW_MI
