On 05/08/2017 08:56 PM, Eric Blake wrote:
Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org>
---
include/hw/misc/unimp.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/include/hw/misc/unimp.h b/include/hw/misc/unimp.h
index 3462d85836..353ee19abf 100644
--- a/include/hw/misc/unimp.h
+++ b/include/hw/misc/unimp.h
@@ -8,6 +8,9 @@
#ifndef HW_MISC_UNIMP_H
#define HW_MISC_UNIMP_H
+#include "qemu/osdep.h"
NACK. .h files should not include osdep.h, because the .c file that is
using the .h file should have already done so. This is mentioned in
HACKING.
I'm not sure this kind of mistake happens often enough, but it might
worth add a such test in checkpatch.pl (easier to say than to implement :p)
