Re: [Qemu-devel] [PATCH 03/11] hw/arm/aspeed: Add an Aspeed machine class

2018-09-18 Thread Cédric Le Goater
On 09/18/2018 08:40 PM, Peter Maydell wrote: > On 31 August 2018 at 11:38, Cédric Le Goater wrote: >> The code looks better, it removes duplicated lines and it will ease >> the introduction of common properties for the Aspeed machines. >> >> Signed-off-by: Cédric Le Goater >> --- >> include/hw/a

Re: [Qemu-devel] [PATCH 03/11] hw/arm/aspeed: Add an Aspeed machine class

2018-09-18 Thread Peter Maydell
On 31 August 2018 at 11:38, Cédric Le Goater wrote: > The code looks better, it removes duplicated lines and it will ease > the introduction of common properties for the Aspeed machines. > > Signed-off-by: Cédric Le Goater > --- > include/hw/arm/aspeed.h | 46 + > hw/arm/aspeed.c

[Qemu-devel] [PATCH 03/11] hw/arm/aspeed: Add an Aspeed machine class

2018-08-31 Thread Cédric Le Goater
The code looks better, it removes duplicated lines and it will ease the introduction of common properties for the Aspeed machines. Signed-off-by: Cédric Le Goater --- include/hw/arm/aspeed.h | 46 + hw/arm/aspeed.c | 212 +--- 2 files changed,