On 09/18/2018 08:40 PM, Peter Maydell wrote: > On 31 August 2018 at 11:38, Cédric Le Goater <c...@kaod.org> wrote: >> The code looks better, it removes duplicated lines and it will ease >> the introduction of common properties for the Aspeed machines. >> >> Signed-off-by: Cédric Le Goater <c...@kaod.org> >> --- >> include/hw/arm/aspeed.h | 46 +++++++++ >> hw/arm/aspeed.c | 212 +++++++++++++--------------------------- >> 2 files changed, 116 insertions(+), 142 deletions(-) >> create mode 100644 include/hw/arm/aspeed.h >> >> diff --git a/include/hw/arm/aspeed.h b/include/hw/arm/aspeed.h >> new file mode 100644 >> index 000000000000..2b77f8d2b3c8 >> --- /dev/null >> +++ b/include/hw/arm/aspeed.h >> @@ -0,0 +1,46 @@ >> +/* >> + * Aspeed Machines >> + * >> + * Copyright 2018 IBM Corp. >> + * >> + * This code is licensed under the GPL version 2 or later. See >> + * the COPYING file in the top-level directory. >> + */ >> +#ifndef _ARM_ASPEED_H >> +#define _ARM_ASPEED_H > > Leading underscore followed by capital is a C reserved > identifier. This should just be ARM_ASPEED_H.
Ah yes. I will fix that. Thanks, C. > Patch looks good otherwise. > > thanks > --- PMM >
