Re: [Qemu-devel] [PATCH 03/11] block: add transactional callbacks feature

2015-03-17 Thread John Snow
On 03/17/2015 02:18 PM, Eric Blake wrote: On 03/17/2015 12:04 PM, John Snow wrote: +typedef void (CallbackFn)(void *opaque, int ret); + +/* Temporary. Removed in the next patch. */ Actually, no. :-) (remove in patch 7) Why are you making them non-static in the first place? I see both func

Re: [Qemu-devel] [PATCH 03/11] block: add transactional callbacks feature

2015-03-17 Thread Eric Blake
On 03/17/2015 12:04 PM, John Snow wrote: >>> +typedef void (CallbackFn)(void *opaque, int ret); >>> + >>> +/* Temporary. Removed in the next patch. */ >> >> Actually, no. :-) >> >> (remove in patch 7) >> >> Why are you making them non-static in the first place? I see both >> functions mentioned in

Re: [Qemu-devel] [PATCH 03/11] block: add transactional callbacks feature

2015-03-17 Thread Max Reitz
On 2015-03-17 at 14:04, John Snow wrote: On 03/17/2015 01:47 PM, Max Reitz wrote: On 2015-03-04 at 23:15, John Snow wrote: The goal here is to add a new method to transactions that allows developers to specify a callback that will get invoked only once all jobs spawned by a transaction are co

Re: [Qemu-devel] [PATCH 03/11] block: add transactional callbacks feature

2015-03-17 Thread John Snow
On 03/17/2015 01:47 PM, Max Reitz wrote: On 2015-03-04 at 23:15, John Snow wrote: The goal here is to add a new method to transactions that allows developers to specify a callback that will get invoked only once all jobs spawned by a transaction are completed, allowing developers the chance to

Re: [Qemu-devel] [PATCH 03/11] block: add transactional callbacks feature

2015-03-17 Thread Max Reitz
On 2015-03-04 at 23:15, John Snow wrote: The goal here is to add a new method to transactions that allows developers to specify a callback that will get invoked only once all jobs spawned by a transaction are completed, allowing developers the chance to perform actions conditionally pending compl

[Qemu-devel] [PATCH 03/11] block: add transactional callbacks feature

2015-03-04 Thread John Snow
The goal here is to add a new method to transactions that allows developers to specify a callback that will get invoked only once all jobs spawned by a transaction are completed, allowing developers the chance to perform actions conditionally pending complete success or complete failure. In order