Re: [Qemu-devel] [PATCH 03/10] tests/vhost-user-bridge: workaround stale vring base

2016-06-13 Thread Michael S. Tsirkin
On Thu, Jun 09, 2016 at 12:25:54PM +0200, Marc-André Lureau wrote: > Hi > > On Thu, Jun 9, 2016 at 12:07 PM, Victor Kaplansky wrote: > > What if set_vring_base is called after set_vring_addr? > > Maybe it is worth to add the fixup to the set_vring_base as well? > > It would need to handle condit

Re: [Qemu-devel] [PATCH 03/10] tests/vhost-user-bridge: workaround stale vring base

2016-06-09 Thread Marc-André Lureau
Hi On Thu, Jun 9, 2016 at 12:07 PM, Victor Kaplansky wrote: > What if set_vring_base is called after set_vring_addr? > Maybe it is worth to add the fixup to the set_vring_base as well? It would need to handle conditions like set_vring_base() being called while set_vring_addr() is not yet, and th

Re: [Qemu-devel] [PATCH 03/10] tests/vhost-user-bridge: workaround stale vring base

2016-06-09 Thread Victor Kaplansky
On Mon, Jun 06, 2016 at 06:45:01PM +0200, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > This patch is a similar solution to what Yuanhan Liu/Huawei Xie have > suggested for DPDK. When vubr quits (killed or crashed), a restart of > vubr would get stale vring base from QEMU. That

[Qemu-devel] [PATCH 03/10] tests/vhost-user-bridge: workaround stale vring base

2016-06-06 Thread marcandre . lureau
From: Marc-André Lureau This patch is a similar solution to what Yuanhan Liu/Huawei Xie have suggested for DPDK. When vubr quits (killed or crashed), a restart of vubr would get stale vring base from QEMU. That would break the kernel virtio net completely, making it non-work any more, unless a dr